Done:
https://salsa.debian.org/go-team/packages/dh-golang/commit/c3e82714f47ca715aae2ceae5f32297180a09285

On Tue, Dec 18, 2018 at 8:24 PM Tong Sun <[email protected]> wrote:

> Sorry Michael, I'm still not too sure what to correct and how to
> correct, although I understand your explanation clearly.
> I'll pass this time (but will take up other tasks that I am capable of
> in the future).
>
> Thx again.
> On Tue, Dec 18, 2018 at 12:09 PM Michael Stapelberg
> <[email protected]> wrote:
> >
> > The DH_GOPKG variable defaults to the value of the XS-Go-Import-Path
> debian/control field.
> >
> > If you don’t reference DH_GOPKG in any of the rules, you can therefore
> omit it.
> >
> > The example you found should be updated to no longer include DH_GOPKG,
> but to include XS-Go-Import-Path. Could you send a pull request please?
> >
> > Thank you,
> >
> > On Sun, Dec 16, 2018 at 5:24 AM Tong Sun <[email protected]> wrote:
> >>
> >> Does Binary-only package still need to set the DH_GOPKG variable?
> >>
> >> >From https://go-team.pages.debian.net/packaging.html, it says:
> >>
> >> - - - - - - - -
> >> dh-golang comes with an example debian/rules file:
> >>
> https://salsa.debian.org/go-team/packages/dh-golang/blob/master/example/rules
> >>
> >> You will need to change the value of DH_GOPKG to correspond to your
> >> program’s upstream package name.
> >> - - - - - - - -
> >>
> >> Is such "changing the value of DH_GOPKG" step still necessary?
> >>
> >> Comparing to
> https://salsa.debian.org/go-team/packages/dh-golang/blob/master/example/rules
> >> my rule file at
> >>
> https://salsa.debian.org/go-team/packages/ffcvt/blob/master/debian/rules
> >> doesn't have the DH_GOPKG variable but it still builds OK.
> >>
> >> Hence the question.
> >>
> >> My whole build log is at:
> >> http://paste.debian.net/1056050/
> >>
> >> Thx.
> >>
> >
> >
> > --
> > Best regards,
> > Michael
>


-- 
Best regards,
Michael

Reply via email to