Hi, I've fixed all required by Dmitry, and updated the upstream and salsa repo at:
https://salsa.debian.org/go-team/packages/ffcvt The package was tested on both gbp and sbuild. It's also lintian-clean. http://paste.debian.net/1123922/ Could you reviewing/sponsoring this please? The source package has been uploaded to mentors.debian.net FYC, ref below. Thanks ------------------------------------------------------------ ---------- Forwarded message --------- From: mentors.debian.net <[email protected]> Date: Wed, Jan 1, 2020 at 6:27 PM Subject: ffcvt uploaded to mentors.debian.net To: <[email protected]> Hi. Your upload of the package 'ffcvt' to mentors.debian.net was successful. Others can now see it. The URL of your package is: https://mentors.debian.net/package/ffcvt The respective dsc file can be found at: https://mentors.debian.net/debian/pool/main/f/ffcvt/ffcvt_1.5.05-1.dsc ------------------------------------------------------------ On Mon, Dec 30, 2019 at 12:48 AM Dmitry Smirnov <[email protected]> wrote: > > On Monday, 30 December 2019 3:32:36 PM AEDT Tong Sun wrote: > > So, hopefully I can leave the "config.go" as is, *for now*. OK? > > You may know specifics of this very package better but I disagree because re- > building all generated files is required for build integrity and for best > practice. There is nothing to loose if "go generate" does not break the build > and maybe something to gain in case of changes that have potential to modify > the generated files - even if such change is in the golang istelf or within > the very library. > > If suddenly "go generate" stops to work then it will serve as an important > indicator of breaking changes that you should know about. > > Re-building all pre-generated files is an important guarantee of DFSG > compliance since all pre-built files must be possible to re-build from > source. > > I therefore insist that all pre-built files must be re-built from source > whenever possible. I can not recognise "we don't have to" and "I'd rather > not" reasons as legitimate excuses. :) > > I hope it makes sense. > > -- > Best wishes, > Dmitry Smirnov. > > --- > > Truth — Something somehow discreditable to someone. > -- H. L. Mencken, 1949
