Thanks for the explanation. TIL: gbp-export-orig is a tool that I must have totally missed. Thanks for pointing me to it.
Nevermind my comment about the maintainer field, I must have been very confused by something else. It's fine! I've just uploaded the package to experimental. Thanks for working on it! -rt On Fri, Jul 17, 2020 at 10:02 AM El boulangero <[email protected]> wrote: > Hi Reinhard, > > thanks for your quick reply! > > The package was created with dh-make-golang 0.3.3-1, so it should match > the latest best practice from the Go team. Note that I can build the > package with the command 'gbp buildpackage --git-builder=sbuild' (in other > words, I never used dgit, I go with gbp and sbuild). > > > How to get the original tarball? > > So, indeed, origtargz fails to fetch it, I just tried. It seems that > origtargz doesn't know what to do with the version string. ' > 0.4.0+git20190919.681d7bb-1' roughly means "git commit 681d7bb, from > 2019/09/19, after the tag 0.4.0". This kind of version string is more or > less standard for Go packages, when we package a git commit. This > particular version string was created by dh-make-golang, I didn't invent it > :) > > Note that for this package, I chose to package the latest commit because > there was not much activity upstream after the tag 0.4.0, and it's not sure > that there will be a new release any time soon (quite unlikely). So better > stick with latest commit on master. > > To answer your question: gbp can recreate the origtargz with the command > `gbp export-orig`. gbp will create the orig tarball from the git tree. Then > running dgit should work. > > I don't know what should be done to accommodate dgit in this case... > > > please target 'experimental' in debian/changelog for NEW packages > > Up to now I would target UNRELEASED, and let the Debian Developer who > uploads the package finalize the changelog. So it would be his decision to > decide between experimental or unstable. > > But I would be surprised to target experimental, from my understanding > experimental is not for new packages, it's for, well, experiments, either > things that might break the system, or that are definitely not ready for > unstable, or any other good reason. > > This package is just a small command-line tool to parse HTML, it has no > interaction whatsoever with the system, it's quite safe. > > In any case, I let the uploader decide on that, I'm fine if the package > ends up in experimental. > > EDIT: I just read in my notes that for Bullseye, it was suggested to go > through experimental, it was mentioned on debian devel announce a while > ago. I understand your comment now :) > > Do you want me to change it, or are you fine doing it yourself (assuming > you'd upload the package)? > > > The maintainer field is not set to the team > > I don't understand, I have that in the control file: > > Maintainer: Debian Go Packaging Team <[email protected]> > Uploaders: > Arnaud Rebillout <[email protected]>, > > Is it correct? > > > - > debian/copyright is (license-reconcile) clean, thanks! > - > debian/{rules,control} is clean > > > Cool :) > > Best, > > Arnaud > > > On Fri, Jul 17, 2020 at 6:26 PM Reinhard Tartler <[email protected]> > wrote: > >> I'd love to help, but I'm stuck at this step: >> >> siretart@x1:/srv/scratch/packages/go-team-sponsorship/pup$ dgit --gbp >> sbuild --run-lintian --run-piuparts >> Format `3.0 (quilt)', need to check/update patch stack >> gzip: warning: GZIP environment variable is deprecated; use an alias or >> script >> dgit: split brain (separate dgit view) may be needed (--quilt=gbp). >> examining quilt state (multiple patches, gbp mode) >> dpkg-source: error: missing orig.tar or debian.tar file in v2.0 source >> package >> dgit: failed command: sh -ec 'exec dpkg-source --no-check --skip-patches >> -x fake.dsc >/dev/null' >> >> dgit: error: subprocess failed with error exit status 255 >> siretart@x1:/srv/scratch/packages/go-team-sponsorship/pup$ origtargz >> W: Unable to locate package pup >> Trying uscan --download --download-current-version ... >> uscan warn: In debian/watch no matching hrefs for version >> 0.4.0+git20190919.681d7bb in watch line >> https://github.com/ericchiang/pup/tags .*/v?(\d\S*)\.tar\.gz debian >> Could not find any location for pup_0.4.0+git20190919.681d7bb.orig.tar.* >> >> How to get the original tarball? >> >> Another couple of minor things: >> >> - please target 'experimental' in debian/changelog for NEW packages >> - The maintainer field is not set to the team, but the Uploaders >> field. Most packages I've seen do this the other way around. I wonder >> whether this inconsistency shouldn't be avoided? >> - debian/copyright is (license-reconcile) clean, thanks! >> - debian/{rules,control} is clean >> >> >> All the best, >> -rt >> >> On Fri, Jul 17, 2020 at 12:50 AM El boulangero <[email protected]> >> wrote: >> >>> Hi Go Team, >>> >>> Is anyone interested in 'pup', a html command-line parser? It's pretty >>> similar to jq, with the difference that 'jq' is for json, while 'pup' is >>> for html. >>> >>> I packaged it, sent the ITP, everything, I just need someone who's >>> willing to give it a quick review, and upload it to NEW, as I'm DM and not >>> DD. >>> >>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965102 >>> https://salsa.debian.org/go-team/packages/pup >>> >>> Cheers, >>> >>> Arnaud (previously [email protected], now >>> [email protected]) >>> >> >> >> -- >> regards, >> Reinhard >> > -- regards, Reinhard
