Dear Golang Team, On Mon, Feb 15, 2021 at 1:23 PM Paul Gevers <[email protected]> wrote:
> On 15-02-2021 15:08, Reinhard Tartler wrote: > > Control: severity -1 important > > I agree with this. The Debian infra allows for use of the internet (if > not used to download programs, that's forbidden by ftp-master [1].) > [...] > > The package itself appears to be fine. The tests fail if and only if the > > test setup doesn't provide (proper) internet connectivity. In fact, it > > tries at test time to reach http://httpbin.org/get > > <http://httpbin.org/get> - a service aimed at developing and debugging > > programs that do HTTP/REST calls. > [...] > Please a the "needs-internet" restriction. It's there for this reason. > Your package seems to have never failed in testing, so, from the Debian > side of things, it looks you're fine. [...] > > 1) test that require internet to test if certain API's out there work > are fine *if* annotated with the needs-internet restriction. Personally, > I consider using on-line frameworks for that acceptable if the effort to > fake is high (that's often the case for maintainers in downstreams like > Debian) > 2) if possible, those tests should be in a separate autopkgtest > paragraph, such then when needs-internet tests are skipped (e.g. because > the infra doesn't provide access, like in Ubuntu) the rest of the tests > are still run. > This package doesn't (like most golang-packages) install a debian/tests/control file, but instead has a field 'Testsuite: autopkgtest-pkg-go' in debian/control instead. How to add the 'needs-internet' restriction to this testsuite? -- regards, Reinhard
