On 7/5/21 12:02 AM, Flu0r1ne wrote:> [1] https://salsa.debian.org/go-team/packages/nebula
I have something to ask here, before upload:
You are installing the example config.yml into /etc right?
I feel being an example file, it really should be installed as an example, i.e.
d/example
Installing something in /etc/ would essentially mean that it is a "default"
config file
- It does not look like a good default, since it seems to bind via
ports, assumes users and groups, etc
- It also sources things from /etc/nebula/*.crt -- and these things
will not be installed when installing the package
- Hence, the systemd service will fail at start unless user manually
fixes all of it and starts the service
Can you make a saner default (i.e. config.yml for nebula)?
If not, it might be better to remove this altogether and install as example
instead, and leave the onus on user to set it up
Or, you could write a maintainer script to ask these questions during
installation and make a sane default config.yml
> [2] https://salsa.debian.org/go-team/packages/golang-github-flynn-noise
Uploaded this, with a few changes.
* You removed vectors.txt in d/rules, however that'd make autopkgtests fail
because it wouldn't be able to
find that in an installed package
* Minor fix in copyright
All changes pushed to salsa, please take a look
> [3]
> https://salsa.debian.org/go-team/packages/golang-github-nbrownus-go-metrics-prometheus
For this one, it looks like a fork of
https://github.com/deathowl/go-metrics-prometheus
and the original repo looks more frequently updated. Would it not be possible
to package the original and patch out the import paths?
If not, will it not be possible to merge changes into the original repo?
IMO, packaging fork is suboptimal, unless the original one is abandoned and/or
unmaintained and someone is willing to maintain fork long time
which doesn't seem to be the case here.
> [5] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=990682
It seems like you opened 2 ITPs for this one by mistake, I reopened both and
forcemerged them
Please note: Record your ownder as: "Alex David <[email protected]>" In
future, as
[email protected] can reach you easily if you do that for processing replies.
Once you reply my questions above, and it looks fine, I'll upload right away.
Thank you for your work! :)
PS: Your email client seems to be appending a blank line after every line of
reply you type,
and it's a bit annoying to quote long emails from you. Can you please fix this?
Also, do I need to reply to you and CC the list everytime, or are you already
subscribed and I simply reply to the list?
Nilesh
signature.asc
Description: OpenPGP digital signature
