On Tue, Jan 4, 2022 at 1:45 PM Nilesh Patra <[email protected]> wrote: > > Hi again, > > On 1/4/22 1:14 PM, Nilesh Patra wrote: > > On 1/4/22 9:22 AM, Tong Sun wrote: > >> Dear Go team, > >> > >> I am looking for a sponsor for the package "easygen". > >> > >> I pushed to our team's Salsa: > >> > >> https://salsa.debian.org/go-team/packages/easygen > >> https://salsa.debian.org/go-team/packages/easygen/-/jobs/2335260 > >> > >> This is an update to the old version and was tested on both gbp and > >> sbuild. It's also lintian-clean. > >> > >> Could you please reviewing/sponsoring pls? > > > > Uploaded. Do you have plans of adding autopkgtests for this? (apart from > > the default smoke tests)
Ops, just saw it, Thanks. OK, let me take a look at the autopkgtests how-to first ... > There were some pitfalls failing the :any and :all builds (FTBFS, basically) > > You had this in d/rules: > > |override_dh_auto_install: > | dh_auto_install # -- --no-source > | dh_install -p$(BINPKG) usr/bin/easygen > | dh_install -p$(LIBPKG) --exclude=.gitignore usr/share/gocode > > Since there is a arch-indep and and arch-dep binary package, doing so is > incorrect. You need to declare > these rules specifically with a "override_dh_auto_install-indep" and > "override_dh_auto_install-arch" > > However, for this package it is simply easier to add .install files for both. > Also, it is better to prefix files like > d/docs, d/examples etc with the binary package it is meant for > (d/easygen.docs,d/easygen.examples) etc. > > I have pushed a few changes to salsa and uploaded. Please take a look. Oh, thanks for doing that, Nilesh. As I understand what you were saying but didn't know how to do them, until I saw all your changes. Thanks again!
