Version: 1.2.6-1 On Fri, Apr 14, 2023 at 12:40:11AM +0800, Shengjing Zhu wrote: > The patch is on upstream master branch and not tagged. So all > consumers expect pdoman haven't used that. It makes me worry. > > Maybe we could ask upstream if they can tag a new version, to indicate > they are confident about the change?
My understanding is: * This was reported as https://github.com/containers/podman/issues/15944 * This is an underlying issue with klauspost/pgzip, with a fix in the PR: https://github.com/klauspost/pgzip/pull/50 * The PR was merged, as commit 17e8dac29df8ce00febbd08ee5d8ee922024a003: "Consume z.current prepared by Reader.Read in Reader.WriteTo (#50)"' and subsequently tagged as v1.2.6: $ git log --oneline -n 1 17e8dac29df8ce00febbd08ee5d8ee922024a003 17e8dac (HEAD -> master, tag: v1.2.6, origin/master, origin/HEAD) Consume z.current prepared by Reader.Read in Reader.WriteTo (#50) * The aforementioned upstream podman issue has been resolved, due to them vendoring a version of pgzip that fixes this issue. In Debian we use the system copy from src:golang-github-klauspost-pgzip. * Debian has src:golang-github-klauspost-pgzip 1.2.6-1, which, as mentioned above, contains a fix for this bug. * podman 4.7.2+ds1-2 has been built against golang-github-klauspost-pgzip-dev 1.2.6-1 in (at least) amd64, as evident from Built-Using. So, therefore I believe this bug has been fixed. For good measure, I ran the reproduction steps as outlined in the first message of this bug report, and cannot reproduce this behavior. Resolving this bug, and I'll close Reinhard's MR #4 as well. Thanks, Faidon
