Hi! > > I uploaded golang-golang-x-mod to unstable now, having had success > > uploading golang-golang-x-sys and migrating it (which seems like a > > similar package as golang-golang-x-mod with many reverse dependencies). > > It’s an easy mistake to make since in both projects, gbp.conf doesn’t specify > upstream tags, but the Salsa projects for x-mod and x-sys track upstream > commits; the latest bumps imported the upstream changes as a single commit. > > Does anyone know if there’s a reason not to set this up in gbp.conf?
All Go team packages should have a debian/gbp.conf that defines the per-package conventions. Doing the upstream import should always be done by issuing simply: gbp import-orig --uscan ..and it will do the correct thing based on debian/gbp.conf contents. You should not be passing in manually `upstream-vcs-tag`, but you should put it in debian/gbp.conf permanently so anyone importing the package will automatically follow the same convention. Good default debian/gbp.conf template from https://github.com/Debian/dh-make-golang/blob/c6fdafd2b864e378ff025dc7b0ed188636e38de3/template.go#L351-L376: ************************** # Lax requirement to use branch name 'debian/latest' so that git-buildpackage # will always build using the currently checked out branch as the Debian branch. # This makes it easier for contributors to work with feature and bugfix # branches. ignore-branch = True # The Debian packaging git repository may also host actual upstream tags and # branches, typically named 'main' or 'master'. Configure the upstream tag # format below, so that 'gbp import-orig' will run correctly, and link tarball # import branch ('upstream/latest') with the equivalent upstream release tag, # showing a complete audit trail of what upstream released and what was imported # into Debian. # # TODO: Most Go packages have tags of form 'v1.0.0', but must be double-checked. upstream-vcs-tag = v%(version%~%-)s # If upstream publishes tarball signatures, git-buildpackage will by default # import and use the them. Change this to 'on' to make 'gbp import-orig' abort # if the signature is not found or is not valid. # # Most Go packages don't publish signatures for the tarball releases, so this is # not enabled by default. #upstream-signatures = on # Ensure the Debian maintainer signs git tags automatically. sign-tags = True ************************** If you want to have all my dh-make-golang improvements automatically, use https://salsa.debian.org/otto/dh-make-golang/-/jobs/8339383/artifacts/raw/debian/output/dh-make-golang_0.8+git20250820.a6fe7fa-1~otto+salsaci+20250923+43_amd64.deb next time you create a new Go package. If you want to have it permanently solved, please "vote" in favor of it by adding your approval to this and other PRs I've filed at https://github.com/Debian/dh-make-golang/pulls/ottok
