Hi!

I am happy to see review requests as Merge Requests! It is so easy to
review the changes commit-by-commit and give feedback, and later
return to re-review and see exactly what was updated, and everything
is in context. Some people push stuff to Salsa and ask review by
email, which at least for me seems very cumbersome, in particular when
it is time to see what changed after the first round of feedback.
Reviewing actual MRs feels like an efficient use of time, so I'm happy
to do it.

I reviewed this
https://salsa.debian.org/go-team/packages/golang-github-twpayne-go-pinentry/-/merge_requests/1
- looks good!

Also reviewed the related:
https://salsa.debian.org/go-team/packages/tkey-ssh-agent/-/merge_requests/1
https://salsa.debian.org/go-team/packages/yubikey-agent/-/merge_requests/1

I can upload these once I get some replies to my comments from Vincent.

- Otto

Reply via email to