On Sun, 2026-06-21 at 09:47:09 +0200, Andrew Lee wrote: > On Sat, Jun 6, 2026 at 2:09 PM Pirate Praveen <[email protected]> > wrote: > > Many new contributors I reviewed/sponsored made this mistake of > > committing generated files (not specific to golang). So I have to > > explicitly tell them to not git add . nor git add debian at least run > > debclean before committing files. But I don't think we need to handle > > this automatically at the cost of making it not source reproducible. > > I think this is always a good chance to get educated for new > contributors while their reviewing process. So that they learn they > should do `git status` before commit and do all their commits with > cares and love. > > And I found it's been annoying for me. I have to run `rm > debian/.gitignore` first at all with all the go packages I have been > working on in the past. > > There are still a lot of missing dependencies for me to packaging for > some packages. As the discussion and also the comment in the PR on > github, we found there is no benifit for having `debian/.gitignore` > file. Please merge and make a new upload ASAP: > https://github.com/Debian/dh-make-golang/pull/317
I find the assertion that there's no found benefit for having debian/.gitignore rather strange and surprising (also given what was mentioned in this thread and the PR). I assume people that manage upstream projects or any other kind of git repo use .gitignore in some way, and understand its usefulness? I mean, sure one can work without them, but the same could be said about so many other things, including git itself. When I need to touch a git package that's usually one of the things I fix first, because otherwise it becomes extremely annoying. > So I don't have to run `rm debian/.gitignore` all the time. :) Is you reason for removing this file also the problem with dgit misbehaving with it? Thanks, Guillem
