Andrew Lee <[email protected]> writes: > Dear Simon, > > This is not blindly rebuild but by necessary. > > The missing go.mod file breaks module-aware builds since dh-golang version > 1.66 switch to module-aware builds with GO111MODULES=on where we are now > testing it in experimental.
Thanks for explaining -- I withdraw my comment :) > And dh-golang starts to ship go.mod file since version 1.64. All the go > related -dev packages built before depends on dh-golang version 1.64 do not > ship go.mod file by default. > > That’s why we need to rebuild -dev package with current dh-golang in > unstable. So that we can continue our test with module-aware builds in > experimental. > > Please let us know if you have any other concerns. I’ll proceed with the > list from Toddy. And I will do double check to confirm if the go.mod file > already shipped in package or not before do the upload. It would be nice if other issues (e.g., Standards-Version, Rules-Requires-Root, Priority:optional, compat 14 etc) could be fixed too.. if we are doing mass uploads. /Simon > This will probably happen after I arrived in debcamp venue later today. > > Happy hacking, > > -Andrew > > Simon Josefsson <[email protected]>於 2026年7月13日週一，13:24寫道： > >> "Dr. Tobias Quathamer" <[email protected]> writes: >> >> > Hi Simon, >> > >> > Am 13.07.26 um 17:59 schrieb Simon Josefsson: >> >> Before doing random source-only uploads, couldn't we at least somehow >> >> confirm that the packages in your list has the problem? >> > >> > I don't quite understand what you mean by "the problem". >> > >> > If you mean that they do not include go.mod and go.sum files from >> > subdirectories, then I'd think that currently, all those packages don't >> > include go.mod and go.sum files in their binary package. >> > >> > That's what I've tried to check with the grep command. In the source >> > code, there are go.mod files in subdirectories. But the dh-golang helper >> > copies those files by default since 1.64, uploaded on 2026-05-08. So >> > every package with a last upload prior to that date won't have go.mod >> > files from subdirectories installed in the binary package. >> > >> > But maybe I didn't understand you correctly? >> >> Sorry I was unclear: what I meant was that there could be some set of >> packages that DO have a go.mod/go.sum in a sub-directory, but it is not >> included in the golang-*-dev package, but that this fact does not cause >> any problem. What I'd like for us to confirm is that we are solving an >> actual problem, rather than just blindly adding go.sum and go.mod files. >> >> Maybe confirming this is just really boring work, and you are confident >> that it solves a real problem and there is no false positives, then >> please ignore -- this was just a knee-jerk gut feeling I got when >> reading your e-mail. >> >> Also, maybe there are OTHER more problems that require fixes, which >> suggest maybe we should hold off doing mass uploads to fix merely one >> issue. >> >> I think mass uploads should be mentioned on debian-devel? If we really >> are looking at re-uploading 300+ packages. >> >> /Simon >>
signature.asc
Description: PGP signature
