Hi,
Here another person who is chipping in on the review discussion. As I see it, should the discussion on **when** are extra eyes needed. Subject: Re: debian go team documentation update Reply-To: In-Reply-To: <[email protected]> On Mon, Sep 14, 2026 at 07:22:47PM +0200, Simon Josefsson wrote: > Otto Kekäläinen <[email protected]> writes: > > > Hi, > > <snip>documentation at two places</snip> > > > > Can we agree on something simple to begin with like what we already > > did a couple weeks ago, that for a MR to be accepted in the policy we > > need 5x +1 and then the submitter can merge it? > > Hopefully yes, although I'm not confident that we'll be able to agree on > anything substantial. I confident we can agree on RFC 1925, twelve network truths. > What I suggest instead is to propose small incremental changes that each > can be discussed and is hopefully non-controversial (or it establish a > question that needs more discussion). > > > I suggest you make now the editorial changes you want, and then we see > > if you get 5x +1 on it, and if so, you can merge it. > > It was easier than I thought: the new workflow file did not seem to > duplicate content in the first file from what I could tell. It is hard > to review, but I did not make any edits of the text other than removing > the document heading and locating what I thought was a good place to > paste it -- how about this: > > https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/26 That MR got reviewed and two approvals. And got merged. a Policy I like to see, is consensus on enabling improvement Some extra words on enabling improvement: We aim for good software. So we accept good and keepaway from perfect. Changes are not needed, improvements are encouraged. Reviewing is good, requesting reviews is better. However insisting on review should be considered bad. Our policy should have guidelines on when to ask for a review. Some examples: * Clear risc of breakage * No so clear risc of breakage * In doubt of the larger impact Why I don't want (MUST HAVE 5 or more) reviews mandatory: * too high threshold for simple improvements * blame shifting * takes out the fun of project Groeten Geert Stappers P.S. IMNSHO https://salsa.debian.org/go-team/go-team.pages.debian.net/-/merge_requests/8 did wait far too long for approval. -- Silence is hard to parse
