Hi Daniel,
Thank you for the review! I've addressed all your points, and made a few
additional changes, noted below.
On 2026.10.09 23:07, Daniel Baumann wrote:
d/control:
* when using debhelper 14, you neither need misc:Depends nor
shlibs:Depends, they will automatically be added at built-time.
I also removed Static-Built-Using: ${misc:Static-Built-Using}, since
debhelper 14 applies it automatically as well. Separately, with compat
level 14, dh_auto_install installs to debian/tmp by default, so I added
--destdir=debian/ijq to the existing override_dh_auto_install.
d/copyright:
* consider using a more condensed form and consisten multi-value
entries by using common indenting [...]
I also shortened the GPL-3+ license paragraph and dropped the
redundant Comment field from the debian/* stanza.
rest looks good to me, if you fix above, upload the source package
somewhere (e.g. mentors.debian.net) and copy&paste me the URL to the dsc
file, I'll sponsor the upload.
Here it is:
<https://mentors.debian.net/debian/pool/main/i/ijq/ijq_1.4.0-1.dsc>
One more change: the package now build-depends on
golang-github-gdamore-tcell.v2-dev, instead of the original
golang-github-gdamore-tcell-dev. ijq imports tcell/v2 directly, so I
declare it explicitly now, even though tview brings it in indirectly.
Best regards,
Haoyuan
