Hi Hermes,

On Thu, 2026-11-12 at 07:56 -0400, Hermes Jesus Rodriguez Azuaje wrote:
> Hi Maytham,
> 
> Thanks for the review.
> 
> - mockdns: appreciated — looking forward to the upload.
> - raft: updated d/copyright for tla/etcdraft.tla (Apache-2.0 and
> CC-BY-4.0), Standards-Version 4.7.4, dropped Priority, watch v5 — tip
> 8becd59 on debian/sid.

Uploaded.

[...]
> > >   golang-github-ncruces-go-sqlite3-wasm  5.0.35304-1  ITP #1147545
> > >     
> > > https://salsa.debian.org/go-team/packages/golang-github-ncruces-go-sqlite3-wasm
> > >     pipeline #1169584 success

This package not only has .dat binary blobs in the source, but also
installs them into the .deb binary package, which is a no-no. They
either need to be regenerated from build (and listen in debian/clean),
or excluded completely via repack. Would also benefit from a note in
README.source about what they do.

d/copyright misses parser/ (see parser/LICENSE). README.md states that
most of the code was generated from "SQLite (and other supporing
libraries)" (presumably their source code). SQLite may be public domain
but its autoconf files aren't and "other supporting libraries" probably
aren't either, so this needs to be investigated. There are a bunch of
shell files from upstream that reference these tools, so that could
help.

d/copyright is incorrect wrt. the license for *, LICENSE file is MIT-0,
not Expat.

> > >   golang-github-ncruces-wbt              1.0.0-1      ITP #1146822
> > >     https://salsa.debian.org/go-team/packages/golang-github-ncruces-wbt
> > >     pipeline #1169583 success

Lintian says:

N:
W: golang-github-etcd-io-raft source: incomplete-creative-commons-license 
cc-by-4.0 [debian/copyright:43]
N:
N:   The package appears to be licensed under a Creative Commons license but 
only includes the human-readable summary in the debian/copyright file which is 
not the actual licence. The Creative Commons webpages contains the following
N:   disclaimer:
N:
N:    This deed highlights only some of the key features and terms of the
N:    actual license. It is not a license and has no legal value. You should
N:    carefully review all of the terms and conditions of the actual license
N:    before using the licensed material.
N:
N:    Creative Commons is not a law firm and does not provide legal
N:    services. Distributing, displaying, or linking to this deed or the
N:    license that it summarizes does not create a lawyer-client or any
N:    other relationship.
N:
N:   Please use the full, plain-text version of the license text which may be 
found here:
N:
N:    
https://creativecommons.org/2014/01/07/plaintext-versions-of-creative-commons-4-0-licenses/
N:
N:   Please refer to Bug#903470 and Bug#795402 for details.
N:
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/copyright/dep5
N:
N:

> > >   golang-github-ncruces-sort             1.0.0-1      ITP #1146820
> > >     https://salsa.debian.org/go-team/packages/golang-github-ncruces-sort
> > >     pipeline #1169582 success

d/copyright tells me to go look at /usr/share/common-licenses/MIT-0,
which does not exist (base-files in unstable does not ship this). The
license needs to be copied from LICENSE.

> > >   golang-github-ncruces-julianday        1.0.0-1      ITP #1146784
> > >     
> > > https://salsa.debian.org/go-team/packages/golang-github-ncruces-julianday
> > >     pipeline #1168970 success

Uploaded.

> > > Upload order unchanged:
> > > 
> > >   wasm + wbt + sort + julianday  ->  go-sqlite3 (#1146823)  ->  pgwd 
> > > (#1142405)

Many of the packages have this hint:

N:
W: golang-github-etcd-io-raft source: 
go-library-package-does-not-include-version golang-github-etcd-io-raft-dev
N:
N:   This Golang package contains a versioned suffix /vN in go.mod but the name 
of the library package does not include -vN-dev as suffix.
N:
N:   Please refer to 
https://wiki.debian.org/Teams/DebianGoTeam/ModuleAwareBuilds for details.
N:
N:   Visibility: warning
N:   Show-Always: no
N:   Check: languages/golang/module-path
N:

It would be great if you're able to fix this.

Would also be great as well if you could apply the same modernization
that you did for raft for these ncruces packages (I have already done
julianday).

--
Maytham

Reply via email to