Thank you very much! All issues are fixed except for the 14th
> 7. You need to add a libgxml-common package for the locales instead of >having the -dev package install them. Have the library package depend >on this new package. Fixed. https://salsa.debian.org/gnome-team/extras/gxml/-/commit/e8c4bbf7c806ee9bce8059b3027386f5530b74dc > 8. Your patches say Forwarded: yes but they don't appear to have been > forwarded. I think the pkgconf patc I no, but someone else yes! I think the upstream doesn't want to fix it. https://gitlab.gnome.org/GNOME/gxml/-/merge_requests/28 > 9. Please remove Recommends: devhelp. Fixed. https://salsa.debian.org/gnome-team/extras/gxml/-/commit/f20e6dd066ed2dbec30d728c0538585a4e622b38 > 10. Please remove Priority: optional [3] https://salsa.debian.org/gnome-team/extras/gxml/-/commit/af78ea90a6353a598d20c25c470a80e09b832ee0 > 11. The build log has these warnings. Fixed. https://salsa.debian.org/gnome-team/extras/gxml/-/blob/debian/latest/debian/control?ref_type=heads > 12. You can remove the direct Depends libgxml-dev -> gir1.2-gxml-0.20 since > that's handled for us by {gir:Depends} https://salsa.debian.org/gnome-team/extras/gxml/-/commit/cc02632c1dd372295a417206dc710de9c5ba3385 13. The only dependencies that libgxml-0.20-2.0.2 should have are ${misc:Depends}, ${shlibs:Depends} The only depends that gir1.2-gxml-0.20 should have are ${gir:Depends}, ${misc:Depends} Fixed. > 14. Please remove debian/tmp/ from the *.install files. It makes those files > easier to read. I'll fix it for the next release > 15. For the gir package, it's better to use -usr/lib/*-linux-gnu/girepository-* Fixed > 16. Set debian/tests/test1.sh as executable. (It still works without that, > but it's best practice for scripts to be executable.) Fixed. > 17. I recommend removing debian/tests/example.vala and updating test1.sh to > use "examples/vala" instead of "debian/tests" https://salsa.debian.org/gnome-team/extras/gxml/-/commit/393599d3df204dc07b540e90b9a61b9427ead427 > 18. Lintian warns that example.vala doesn't need to be executable. Please > forward that suggestion upstream. I reported it(in issues), but the upstream will not fix it. ;( > 19. The -dev package description says that the package contains the... Fixed
