On Tue, Sep 05, 2000 at 09:35:14PM +0200, Marcus Brinkmann wrote: > On Tue, Sep 05, 2000 at 02:45:09AM -0400, Igor Khavkine wrote: > > Ok, i'll try it out. Having no internet for most of the last week did > > wonders > > for my development work. I was able to test out the pmake patch and also > > produce one for ash. I'm attaching it here. And I'll put it up on my page > > http://alcor.concordia.ca/~i_khavki/ with some comments that anyone who > > wants > > to review the patch should read. > > It looks quite good. There is only one small glitch: > > --- ash-0.3.7/miscbltin.c Sat Sep 2 18:04:01 2000 > +++ ash-0.3.7.new/miscbltin.c Sat Sep 2 18:00:21 2000 > @@ -69,7 +69,7 @@ > > #undef rflag > > -#ifdef linux > +#if defined(__GLIBC__) > mode_t getmode(const void *, mode_t); > void *setmode(const char *); > > > The original code reads: > > #ifdef linux > mode_t getmode(const void *, mode_t); > void *setmode(const char *); > > #if !defined(__GLIBC__) || __GLIBC__ == 2 && __GLIBC_MINOR__ < 1 > typedef enum __rlimit_resource rlim_t; > #endif > #endif > > Note the second #if, which takes effect when you compile on an older linux > version with libc5 or libc4. > > By changing from linux to __GLIBC__, you actually prevent the getmode and > setmode declarations on those platforms. Now you can either say, let's drop > support for those, and then you can remove the second, inner, #if block, or > remain compatible and change to #if defined(__GLIBC__) || defined(linux) > (or something similar). >
I think we should keep support for old libraries since packages for all platforms are compiled from the same source tree. However I still object to using defined(linux) since the features in the #if block are not linux specific but specific to some version of glibc. A better idea would be to investigate if all the defined(__GLIBC__) that I added and see if that alone would suffice or glibc version information has to be added. Igor -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
