2012/1/23 Tanguy LE CARROUR <[email protected]>: > Hi Jérémie, > > Thanks for your comments! > I'll have a look a it later this week but I've already learnt something: I'm > a very bad developer! ^_^'
Don't worry, portability work is harder than it looks. Also, keep in mind the whole point of patch review is to point out imperfections. But it will teach you a lot because you get to read lots of code from many different people, and your code will be read by many different people as well. Besides, as a first attempt your patch was nothing to be ashamed of! I though your log10() trick was smart, if a little bit overkill :-) -- Jérémie Koenig <[email protected]> http://jk.fr.eu.org/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/CA+kCSAZpJ7O07BgkadqkNVO9=-15tyyksgznrc-aif3+_a-...@mail.gmail.com
