Le jeudi 04 septembre 2014 à 00:29 +0200, Samuel Thibault a écrit : > Hello, > > Guillaume Delacour, le Wed 03 Sep 2014 14:13:07 +0200, a écrit : > > http://mentors.debian.net/debian/pool/main/h/hping3/hping3_3.a2.ds2-7.dsc > > It looks good, except that script.c could rather easily be rewritten not > to use PATH_MAX instead of setting an arbitrary value, something like > (untested): > > - char rcfile[PATH_MAX]; > - snprintf(rcfile, PATH_MAX, "%s/.hpingrc", home); > - rcfile[PATH_MAX-1] = '\0'; > + char *rcfile; > + asprintf(&rcfile, PATH_MAX, "%s/.hpingrc", home); > Tcl_EvalFile(interp, rcfile); > Tcl_ResetResult(interp); > + free(rcfile);
I've tested this and the asprintf() call is not correct (and i've just
added a return control on the call):
- char rcfile[PATH_MAX];
- snprintf(rcfile, PATH_MAX, "%s/.hpingrc", home);
- rcfile[PATH_MAX-1] = '\0';
+ char *rcfile;
+ if (asprintf(&rcfile, "%s/.hpingrc", home) < 0)
+ return NULL;
Tcl_EvalFile(interp, rcfile);
Tcl_ResetResult(interp);
+ free(rcfile);
Thanks for your time.
>
> Samuel
--
Guillaume Delacour <[email protected]>
signature.asc
Description: This is a digitally signed message part
