Hi Jan, > > I agree with Dmitry on this point. The IHEX parser should not be inside > > firmware_class.c. What about using keyspan_ihex.[ch] for it? > > That's what I had originally, actually called firmware_ihex.ko, since > the IHEX format parser is not in any way keyspan specific and there are > several usb-serial converters that seem to use the same IHEX->.h trick > which could trivially be modified to use this loader. > > But the compiled parser fairly small (< 2KB) and adding it to the > existing module didn't effectively add any size to the firmware_class > module since things are rounded to a page boundary anyways.
so it seems that this is usb-serial specific at the moment. Then I would propose to add it to the core of the usb-serial driver. Unless no other driver in the kernel needs a IHEX parser, I think it is bad idea to mess it up at the moment. People are also working on a replacement for the current request_firmware(), because the needs are changing. Try to keep it close with the usb-serial for now. Regards Marcel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
