Hi Ben,

I upgraded to tag debian/4.6_rc5-1_exp1 today and wanted to provide some
quick feedback. First of all it's good to no longer have linux-tools
separately, thanks for doing this.


On first build I got messages like this because config.h is only generated
later in the build and the target install-usbip failed:

sed: can't read debian/build/build-tools/tools/usb/usbip/config.h: No such file 
or directory

After invoking "make -f debian/rules binary-arch" a second time the package
was built without a hitch because config.h was now there.


In rules.d/tools/lib/lockdep/Makefile, ln -s fails for liblockdep.so
because the symlink already exists. Either this should be ln -sf or
the command is superfluous.


About this issue I mentioned in my Linux 4.5 e-mail in February:

On Thu, Feb 25, 2016 at 09:41:28PM +0000, Ben Hutchings wrote:
> On Thu, 2016-02-25 at 16:16 +0100, Lukas Wunner wrote:
> > --- 
> > a/debian/patches/features/all/drivers-media-dvb-usb-af9005-request_firmware.patch
> > +++ 
> > b/debian/patches/features/all/drivers-media-dvb-usb-af9005-request_firmware.patch
> > @@ -13,11 +13,7 @@ a version of the script which is directly derived from 
> > the driver.
> >  
> >  --- a/drivers/media/usb/dvb-usb/Kconfig
> >  +++ b/drivers/media/usb/dvb-usb/Kconfig
> > -@@ -227,10 +227,10 @@ config DVB_USB_OPERA1
> > - 
> > - config DVB_USB_AF9005
> > -   tristate "Afatech AF9005 DVB-T USB1.1 support"
> > --  depends on BROKEN
> > +@@ -236,6 +236,7 @@ config DVB_USB_AF9005
> >     depends on DVB_USB
> >     select MEDIA_TUNER_MT2060 if MEDIA_SUBDRV_AUTOSELECT
> >     select MEDIA_TUNER_QT1010 if MEDIA_SUBDRV_AUTOSELECT
> 
> This file is also patched by debian/patches/debian/dfsg/drivers-media-
> dvb-dvb-usb-af9005-disable.patch when building the 'orig' tarball.

So this patch adds "depends on BROKEN":
debian/patches/debian/dfsg/drivers-media-dvb-dvb-usb-af9005-disable.patch

And this patch subsequently removes it:
debian/patches/features/all/drivers-media-dvb-usb-af9005-request_firmware.patch

Forgive me for being dense but what is the motivation for this?

I keep bringing this up because it breaks my workflow: I use
"quilt pop -a" to remove all debian patches before rebasing
or switching branches, and later use "quilt push -a" when I
actually want to compile. I can work around this by keeping
a modified version of the second above-mentioned patch in
my tree but I'm wondering if it might be possible to just not
add the "depends on BROKEN" in the first place?

Thanks,

Lukas

Reply via email to