On 27 January 2017 at 21:09, Ben Hutchings <[email protected]> wrote: > On Fri, 2017-01-27 at 16:02 +0200, [email protected] wrote: >> From: Riku Voipio <[email protected]> >> >> If CONFIG_USB_GADGET is selected, enable all configfs functions as >> modules and most popular legacy modules (ethernet and serial). >> g_nokia left as armhf specific (Nokia N900 tradition) > [...] >> --- a/debian/config/armhf/config >> +++ b/debian/config/armhf/config >> @@ -1114,9 +1114,6 @@ CONFIG_USB_GADGET=m >> ## >> ## file: drivers/usb/gadget/legacy/Kconfig >> ## >> -CONFIG_USB_ETH=m >> -CONFIG_USB_ETH_RNDIS=y >> -CONFIG_USB_GADGETFS=m >> CONFIG_USB_G_NOKIA=m >> >> ## >> diff --git a/debian/config/config b/debian/config/config >> index c744073f9..d6ec09462 100644 >> --- a/debian/config/config >> +++ b/debian/config/config > [...] >> +## >> +## file: drivers/usb/gadget/legacy/Kconfig >> +## >> +CONFIG_USB_ETH=m >> +CONFIG_USB_ETH_RNDIS=y >> +CONFIG_USB_GADGETFS=m >> +CONFIG_USB_FUNCTIONFS=m >> +CONFIG_USB_FUNCTIONFS_ETH=y >> +CONFIG_USB_FUNCTIONFS_RNDIS=y >> +CONFIG_USB_FUNCTIONFS_GENERIC=y >> +CONFIG_USB_G_SERIAL=m > > Sorry to mess you around, but I wonder now if it really makes sense to > enable more of the legacy interface. If I understood correctly, the > configfs interface provides all the same functionality and more, and > userspace should be moving to use that. > > Perhaps we should: > 1. Enable the configfs interface in the top-level config > 2. Leave armhf with limited legacy configuration interface support for > stretch (in case there are users that depend on it) > 3. Disable the legacy interface post-stretch.
I thought about it, but frankly using g_ether and g_serial is so convenient. it's a matter of "modprobe g_ether && dhclient -i usb0". Using the modern configfs way is quite a bit of more steps: http://events.linuxfoundation.org/sites/events/files/slides/USB%20Gadget%20Configfs%20API_0.pdf We would at least need libusbg and gadget-tool (https://github.com/kopasiak/gt) included in debian before deprecating. Riku
