Source: linux
Version: 6.12.73-1
Usertags: pidof-without-procps

Dear maintainer(s) of linux,

it appears that linux uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of linux
  that use `pidof` at runtime;
* via the `Build-Depends:` field of linux, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of linux, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that linux uses `pidof` due to the following
code snippets:

```
path: linux_6.19.6-1/tools/testing/selftests/bpf/test_xdp_features.sh
        ip link del v1 2> /dev/null
        ip netns del ${NS} 2> /dev/null
        [ "$(pidof xdp_features)" = "" ] || kill $(pidof xdp_features) 2> 
/dev/null
}


path: linux_6.19.6-1/tools/testing/selftests/net/fin_ack_lat.sh
cleanup() {
        kill $(pidof fin_ack_lat)
        rm -f $tmpfile
}


path: linux_6.19.6-1/tools/testing/selftests/amd-pstate/tbench.sh
        $PERF stat -a --per-socket -I 1000 -e power/energy-pkg/ tbench -t 
$TIME_LIMIT $PROCESS_NUM > $OUTFILE_TBENCH-perf-$1-$2.log 2>&1
        pid=`pidof tbench_srv`
        kill $pid
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

Reply via email to