Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] docs: kconfig_checker: missing schemas/ directory in schema file
  paths
- [Low] docs: kconfig_checker: empty commit message body
--

commit a4e08eff4d708d44ce736f88aa1913f31f9a424d
Author: Ahmed S. Darwish <[email protected]>

> Documentation: Describe kconfig-checker overlays
>
> Signed-off-by: Ahmed S. Darwish <[email protected]>

[Severity: Low]
Could a commit message body be added to describe the new overlay
documentation and the schema file path updates?

> diff --git a/Documentation/tools/kconfig_checker.rst 
> b/Documentation/tools/kconfig_checker.rst
> index 73717ac56ea9d..152bc0c634eac 100644
> --- a/Documentation/tools/kconfig_checker.rst
> +++ b/Documentation/tools/kconfig_checker.rst

[ ... ]

> @@ -47,4 +51,51 @@ The checker's rule files are written in YAML, and are 
> stored in::
>  
>  The schema for these files is fully documented in::
>  
> -   tools/kconfig-checker/schema.yml
> +   tools/kconfig-checker/base.yml
> +   tools/kconfig-checker/rules.yml

[Severity: Low]
Are the schema file paths here missing the schemas/ directory component?

Commit "kconfig-checker: Split schema to support component reuse" and
commit "kconfig-checker: Introduce overlays schema" placed these files
under tools/kconfig-checker/schemas/ (base.yml, rules.yml, and
overlay.yml).

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=9

Reply via email to