Source: linux
Severity: normal
Tags: patch

Dear kernel team,

The amd64 config enables the Surface Aggregator registry but not the
subsystem-hub driver that the devices declared in that registry depend on.
On a Surface Pro 8 (SAM-over-SSH, ACPI HID MSHW0263) the detachable type
cover -- keyboard, touchpad and tablet-mode switch -- is then never
instantiated, even though every other piece is present.

0. Current state

Neither option appears in debian/config/amd64/config as of 2026-11-10
(debian/latest, linux 7.3.3-1). That file has SURFACE_AGGREGATOR_REGISTRY
(line 1620) and SURFACE_AGGREGATOR (line 1630); SURFACE_AGGREGATOR_HUB and
SURFACE_AGGREGATOR_TABLET_SWITCH are absent outright, not merely disabled.

1. Observed behaviour

On Debian 7.3.3-1 (linux-image-7.3.3+deb14-amd64, Surface Pro 8), stock
image, no out-of-tree modules:

  # CONFIG_SURFACE_AGGREGATOR_HUB is not set
  # CONFIG_SURFACE_AGGREGATOR_TABLET_SWITCH is not set
  CONFIG_SURFACE_AGGREGATOR=m
  CONFIG_SURFACE_AGGREGATOR_BUS=y
  CONFIG_SURFACE_AGGREGATOR_REGISTRY=m
  CONFIG_SURFACE_PLATFORMS=y

The KIP hub device is instantiated by the registry but stays unbound, so
its child devices are never created:

  $ cat /sys/bus/surface_aggregator/devices/00:00:01:0e:00/uevent
  MODALIAS=ssam:d00c00t01i0Ef00
  # no 'driver' symlink in that directory

  $ grep -l Surface /sys/class/input/*/name
  # no match -- no keyboard/touchpad input devices exist

2. Why

Upstream v6.0 moved the SSAM subsystem hub drivers out of
surface_aggregator_registry into a separate module (upstream commit
"platform/surface: aggregator: Move subsystem hub drivers to their own
module", by Maximilian Luz), guarded by the new Kconfig symbol
CONFIG_SURFACE_AGGREGATOR_HUB. Its help text states:

  Provides subsystem hub drivers which manage client devices on various
  SSAM subsystems. In some subsystems, notably ... the KIP subsystem
  managing type-cover devices in the Surface Pro 8 and Surface Pro X,
  devices can be (hot-)removed. Hub devices and drivers are required to
  manage these subdevices.
  ...
  Without this module, the respective devices mentioned above will not be
  instantiated and thus any functionality provided by them will be missing,
  even when drivers for these devices are present.

ssam_node_group_sp8[] in surface_aggregator_registry.c (ACPI HID MSHW0263)
references ssam_node_hub_kip plus the KIP children (keyboard, touchpad, pen
stash, fwupd) and ssam_node_kip_tablet_switch. None of them can be created
without the hub driver.

No other symbol selects either option, and all dependencies are already
satisfied in the amd64 config:

  SURFACE_AGGREGATOR_HUB            SURFACE_AGGREGATOR && SURFACE_AGGREGATOR_BUS
  SURFACE_AGGREGATOR_TABLET_SWITCH  SURFACE_AGGREGATOR && 
SURFACE_AGGREGATOR_BUS && INPUT

so both are buildable as-is; they are simply missing from the config file.

This also affects the BAS hub (additional battery/AC devices in the Surface
Book 3 base).

3. Verification

I built surface_aggregator_hub.ko from the v7.3.3 sources against
linux-headers-7.3.3+deb14-amd64 (vermagic matches the running kernel) and
loaded it. The device above bound to surface_aggregator_subsystem_hub and
the following input devices appeared immediately:

  Microsoft Surface 045E:09AE Keyboard
  Microsoft Surface 045E:09B0 Keyboard
  Microsoft Surface 045E:09AF Mouse / Touchpad
  Microsoft Surface KIP Tablet Mode Switch

linux-surface's Debian instructions list surface_aggregator_hub among the
modules needed for the type cover, which is currently the only way these
devices work on a stock kernel. No driver patch is needed, only the two
config options.

(Touchscreen support on this model is a different matter: it uses ITHC in
IPTS mode, which is not in mainline at all. This report does not cover it.)

4. Suggested patch

--- a/debian/config/amd64/config
+++ b/debian/config/amd64/config
@@ -1617,7 +1617,9 @@
 CONFIG_SURFACE3_WMI=m
 CONFIG_SURFACE_3_POWER_OPREGION=m
 CONFIG_SURFACE_ACPI_NOTIFY=m
+CONFIG_SURFACE_AGGREGATOR_HUB=m
 CONFIG_SURFACE_AGGREGATOR_REGISTRY=m
+CONFIG_SURFACE_AGGREGATOR_TABLET_SWITCH=m
 CONFIG_SURFACE_DTX=m
 CONFIG_SURFACE_GPE=m
 CONFIG_SURFACE_HOTPLUG=m

Thanks,

Emfox Zhou <[email protected]>


-- System Information:
Debian Release: forky/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 7.3.3+deb14-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Reply via email to