Dear Debian kernel team, this is decision of the driver author himself.
These corrections are to be made for upstream tree, thus, i think, it's
OK to conform patch quality for you.
Signed-off-by: Oleg Verych <[EMAIL PROTECTED]>
----- Forwarded message from Al Borchers <[EMAIL PROTECTED]> -----
Date: Wed, 14 Mar 2007 03:32:47 -0500
From: Al Borchers <[EMAIL PROTECTED]>
To: Oleg Verych <[EMAIL PROTECTED]>
Cc: Greg KH <[EMAIL PROTECTED]>,
Linux USB <[email protected]>,
[EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: Re: [patch 03/05] ti_usb, device setup: without any artificial errors,
use configuration changing
Oleg --
I tried this on 3410 and 5052 with and without firmware--worked
great.
Please
1) Change return value to 1, rather than 0xO1E and 0xA1B.
(Clever, but it will just confuse readers.)
2) Drop (void) cast on usb_driver_set_configuration.
3) Resend the patch with a signed-off line.
Thanks for doing this--so glad we can get rid of the hotplug
script!
-- Al
Quoting Oleg Verych <[EMAIL PROTECTED]>:
> pp-by: Oleg Verych
> ---
> i.e. no more uGLYdev with sysfs
>
> Alan, i'm looking forward to deal with this crutch :-E
>
> drivers/usb/serial/ti_usb_3410_5052.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Index: linux-2.6.21-rc1/drivers/usb/serial/ti_usb_3410_5052.c
> ===================================================================
> --- linux-2.6.21-rc1.orig/drivers/usb/serial/ti_usb_3410_5052.c
> 2007-02-23
> 05:03:57.691537658 +0100
> +++ linux-2.6.21-rc1/drivers/usb/serial/ti_usb_3410_5052.c 2007-02-23
> 05:22:22.766512292 +0100
> @@ -389,13 +389,13 @@
> usb_reset_device(dev);
> }
>
> - status = -ENODEV;
> + status = 0x01E; /* positive status -- device to be reconfigured
> */
> goto free_tdev;
> }
>
> - /* the second configuration must be set (in sysfs by hotplug script) */
> if (dev->actconfig->desc.bConfigurationValue == TI_BOOT_CONFIG) {
> - status = -ENODEV;
> + (void) usb_driver_set_configuration(dev, TI_ACTIVE_CONFIG);
> + status = 0xA1B;
> goto free_tdev;
> }
>
>
> --
>
>
----- End forwarded message -----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
