On Thu, Mar 22, 2007 at 11:07:06AM +0100, Sjoerd Simons wrote:
> So the patch is really the last bit that needs to be added :)
I did a quick review of the last two versions (0.8.2 and 0.8.3) of the
patch.
- (0.8.2) Moves acpi init into init thread.
- (0.8.3) Populates rootfs two times.
- Uses vfs directly, not the sys_* wrappers. The rootfs code already uses
sys_*, so it seems to be safe. The patch does not document why it does
this that way.
- Introduces a global variable. It does not seem to be necessary. None
of the functions is exported.
- Memory leak. Only one exit path of the override table loader code is
checked.
- Control flow in the loader code is rather weird. It should be readable
from the top to the bottom, not the other way.
- I was not able to find a changelog.
This does not met linux quality standards.
Bastian
--
Live long and prosper.
-- Spock, "Amok Time", stardate 3372.7
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
