On Sun, Feb 22, 2009 at 03:53:22AM +0000, Ben Hutchings wrote: > --- debian/patches/series/orig-0 (revision 12898) > +++ debian/patches/series/orig-0 (working copy) > @@ -1,10 +1,16 @@ > -X debian/dfsg/files-1
There is a reason why this was at the beginning. See the old tg3 patches for details. > ++static const struct firmware *typhoon_fw; const is already static. Why is that a global variable? > ++ pdev = platform_device_register_simple("r128_cce", 0, NULL, 0); > ++ if (IS_ERR(pdev)) { > ++ printk(KERN_ERR "r128_cce: Failed to register firmware\n"); > ++ return PTR_ERR(pdev); > ++ } > ++ rc = request_firmware(&fw, FIRMWARE_NAME, &pdev->dev); > ++ platform_device_unregister(pdev); The drm modules don't register proper devices already? > ++/* Firmware section */ > ++#define FIRMWARE_BDX "tehuti/bdx.bin" > ++static const struct firmware *bdx_fw; Again, why global? > +index efaf84d..dec67e0 100644 > +--- a/drivers/net/tehuti.h > ++++ b/drivers/net/tehuti.h > +@@ -29,6 +29,7 @@ > + #include <linux/if_vlan.h> > + #include <linux/interrupt.h> > + #include <linux/vmalloc.h> > ++#include <linux/firmware.h> > + #include <asm/byteorder.h> This looks wrong. Nothing from firmware.h is used in this header. > + [ Ben Hutchings ] > + * Remove firmware from drivers and make them use request_firmware(): > + - mga (closes: #502666) > + - qla1280 (closes: #502667) > + - r128 (closes: #494007) > + - radeon (closes: #494009) > + - tehuti (closes: #501153) > + - typhoon (closes: #502669) The patches still needs to be accepted upstream. Bastian -- There is a multi-legged creature crawling on your shoulder. -- Spock, "A Taste of Armageddon", stardate 3193.9 -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org