On Mon, Mar 16, 2009 at 02:13:24PM +0300, Kir Kolyshkin wrote: [...] > >The double alloc should not be too much of a problem (or?), but the double > >free, I assume, can result > >in real problems, right? > > > > Right. Tables are leaked.
Ok. [...] > >>http://git.openvz.org/?p=linux-2.6.26-openvz;a=commitdiff;h=b405aed753ac48a46e66cccfd0a37006fd11feb8 > >>netfilter: Add check to the nat hooks > >>OpenVZ Bug #1051 (http://bugzilla.openvz.org/1051). Might be an ABI > >>breaker. > >>Attached as 0048* > >> > > > >Is it this part that you are worried about for the ABI breakage? > > > > /* After packet filtering, change source */ > > { > >- .hook = nf_nat_fn, > >+ .hook = nf_nat_local_in, > > .owner = THIS_MODULE, > > .pf = PF_INET, > > .hooknum = NF_INET_LOCAL_IN, > > > > I'm not sure why I wrote that. It doesn't look like an ABI breaker. > Ok. Adding this for next patch proposal. Best regards, // Ola -- --- Inguza Technology AB --- MSc in Information Technology ---- / [email protected] Annebergsslingan 37 \ | [email protected] 654 65 KARLSTAD | | http://inguza.com/ Mobile: +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
