On Fri, 2010-12-03 at 08:52 +0000, Ian Campbell wrote: > > > IanC: it looks like passing a node id of "-1" is the correct way to > > say "I don't care". > > I thought so too but convinced myself from staring at the code that it > wouldn't work in this case -- I'll double check before I resubmit.
I was mislead because node gets placed verbatim into desc->node which at first glance seemed invalid but on second look it seems to be fine, everything which reads that value is prepared to accept the -1. There is precedent for using -1 in hpet_assign_irq, although most other places seem to use numa_node_id(). I've tested with -1 and it seems ok. I see (too late) that you've already made the change so I guess you knew this ;-) Are you going to put this change into next-2.6.32 as well as 37? Ian. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1291369764.5514.15168.ca...@zakaz.uk.xensource.com
