On Fri, Jan 14, 2011 at 02:47:54PM +0100, Michael Biebl wrote: > On 14.01.2011 14:39, maximilian attems wrote: > > On Fri, Jan 14, 2011 at 02:21:39PM +0100, Michael Biebl wrote: > > > thanks please take a look at git initramfs-tools, it is in one of > > those maks branches, hmm looking up -> maks/preinst_blkid > > http://git.debian.org/?p=kernel/initramfs-tools.git;a=summary > > Ah cool. > > FWIW, I think you can drop the vol_id fallback, as the code will be only run > on > fresh installations anyway, but not on upgrades. > That said, blkid worked fine for me on both lenny and squeeze. > Do you know of cases where e2fsprogs' blkid does not work and using the old > vol_id would be preferable? > I also think, you don't need to run blkid *twice* and you can simply remove > the > "if command ..." check
I prefer longer backward compatibility and not assume commands to be there. the cost of a command call is very small as it is a shell builtin. it is noted to disappear after Wheezy release whenever that may happen. (: good weekend. -- maks -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
