On Sun, Jan 09, 2011 at 06:51:36AM +0000, Ben Hutchings wrote: > I want to apply this to squeeze. I've seen one too many panics with > VMware or VirtualBox modules in them, which appear to be worse than > anything in drivers/staging.
Don't forget to add it to the bug script. > + intree = get_modinfo(sechdrs, infoindex, "intree"); > + if (!intree) > + add_taint_module(mod, TAINT_OOT_MODULE); Is there a reason for not doing this the following way except that you copied the staging check? | if (!get_modinfo(sechdrs, infoindex, "intree")) | add_taint_module(mod, TAINT_OOT_MODULE); The resulting code should be the same[1]. And actually the staging test looks this way in .37. Bastian [1]: http://mirror.fem-net.de/CCC/27C3/mp4-h264-HQ/27c3-4096-en-code_deobfuscation_by_optimization.mp4 -- Where there's no emotion, there's no motive for violence. -- Spock, "Dagger of the Mind", stardate 2715.1 -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
