On Tue, 12 Oct 2004, Colin Watson wrote: > On Tue, Oct 12, 2004 at 03:01:33PM -0500, Micah Anderson wrote: > > It isn't necessary to update that code to have these patches work, > > because I add as a valid interpreter for php and php4 scripts php-cli, > > that error is generated when there isn't a valid interpreter. > > You've changed the tag name; there is code to generate that tag name; > therefore that code needs to be changed.
Ah, I had no idea that the /usr/share/lintian/checks files are generated somewhere/somehow. > Actually, it would almost certainly be easier simply to rename the tag > to 'php-script-but-no-php4-cli-dep', and remove the old php4-cgi entries > in checks/scripts; that way the existing code would work automatically. > Your current patch attempts to assign two values to the same entry in a > hash, so it's not clear to me that it even has defined behaviour. Yeah, sorry about that, I have very limited understanding of the internals of lintian, I assumed the files that existed there were not generated from some place else and I see now that you are right about the hash bit. My scripts.diff patch is obviously of no use. micah
