Author: djpig
Date: 2005-08-27 00:25:24 +0200 (Sat, 27 Aug 2005)
New Revision: 478

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
   trunk/testset/maintainer-scripts/debian/prerm
Log:
+ Don't issue bashism warning on POSIX character classes ([[:foo:]]).
  Noted by Stephen Gran (Closes: #323098)
+ Remove some useless groupings in the bashism regexes


Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts        2005-08-26 21:36:28 UTC (rev 477)
+++ trunk/checks/scripts        2005-08-26 22:25:24 UTC (rev 478)
@@ -455,13 +455,13 @@
                  '[^\\\]\{([^\s]+?,)+[^\\\}\s]+\}', # brace expansion
                  '(?:^|\s+)\w+\[\d+\]=',      # bash arrays, H[0]
                  '[EMAIL PROTECTED]',# bash arrays, ${name[0|*|@]}
-                 '(?:^|\s+)(read\s*(?:;|$))', # read without variable
+                 '(?:^|\s+)read\s*(?:;|$)', # read without variable
                  '((?:test|\[)\s+.+\s-[ao])\s',# test/[ -a/-o binary operators
-                 '(?:^|\s+)(kill\s+-[^sl]\w*)',   # kill -[0-9] or -[A-Z]
-                 '(?:^|\s+)(trap\s+["\']?.*["\']?\s+.*[1-9])', # trap with 
signal numbers
-                 '(?:^|\s+)(local)\s',        # local scoping of variables
-                 '(\&>)',                     # cshism
-                 '(\[\[)',                    # alternative test command
+                 '(?:^|\s+)kill\s+-[^sl]\w*',   # kill -[0-9] or -[A-Z]
+                 '(?:^|\s+)trap\s+["\']?.*["\']?\s+.*[1-9]', # trap with 
signal numbers
+                 '(?:^|\s+)local\s',        # local scoping of variables
+                 '\&>',                     # cshism
+                 '\[\[(?!:)',                    # alternative test command
                );
 
                for my $re (@bashism_regexs) {

Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog      2005-08-26 21:36:28 UTC (rev 477)
+++ trunk/debian/changelog      2005-08-26 22:25:24 UTC (rev 478)
@@ -46,6 +46,10 @@
   * checks/manpages:
     + [FL] Don't issue warnings about 8bit characters in translated
       man pages. Patch by Denis Barbier (Closes: #321650)
+  * checks/scripts:
+    + [FL] Don't issue bashism warning on POSIX character classes ([[:foo:]]).
+      Noted by Stephen Gran (Closes: #323098)
+    + [FL] Remove some useless groupings in the bashism regexes
 
  -- Frank Lichtenheld <[EMAIL PROTECTED]>  Thu,  4 Aug 2005 12:45:33 +0200
 

Modified: trunk/testset/maintainer-scripts/debian/prerm
===================================================================
--- trunk/testset/maintainer-scripts/debian/prerm       2005-08-26 21:36:28 UTC 
(rev 477)
+++ trunk/testset/maintainer-scripts/debian/prerm       2005-08-26 22:25:24 UTC 
(rev 478)
@@ -33,3 +33,7 @@
     kill -HUP $$
 fi
 
+#this is ok though
+if test -n $(echo foo | perl -pe 's/[[:space:]]//go'); then
+    echo 1
+fi


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to