Author: rra
Date: 2008-06-07 02:07:24 +0200 (Sat, 07 Jun 2008)
New Revision: 1348
Modified:
trunk/checks/scripts
trunk/debian/changelog
trunk/testset/maintainer-scripts/debian/postinst
trunk/testset/tags.maintainer-scripts
Log:
* checks/scripts:
+ [RA] Catch deprecated chown syntax even when options are given to
chown. Patch by Raphael Geissert. (Closes: #483775)
Modified: trunk/checks/scripts
===================================================================
--- trunk/checks/scripts 2008-06-07 00:01:08 UTC (rev 1347)
+++ trunk/checks/scripts 2008-06-07 00:07:24 UTC (rev 1348)
@@ -635,7 +635,7 @@
tag 'start-stop-daemon-in-maintainer-script', "$file:$.";
}
# Don't use chown foo.bar
- if (/(chown\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+/) {
+ if
(/(chown(\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+/) {
tag "deprecated-chown-usage", "$file:$. \'$1\'";
}
if (/invoke-rc.d.*\|\| exit 0/) {
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2008-06-07 00:01:08 UTC (rev 1347)
+++ trunk/debian/changelog 2008-06-07 00:07:24 UTC (rev 1348)
@@ -47,6 +47,9 @@
* checks/rules{.desc,}:
+ [RA] Add some basic checks for whether debhelper programs are called
in a reasonable order. (Closes: #471869)
+ * checks/scripts:
+ + [RA] Catch deprecated chown syntax even when options are given to
+ chown. Patch by Raphael Geissert. (Closes: #483775)
* checks/standards-version:
+ [RA] Policy 3.8.0 is now current and anything older than 3.7.2 is
now ancient.
Modified: trunk/testset/maintainer-scripts/debian/postinst
===================================================================
--- trunk/testset/maintainer-scripts/debian/postinst 2008-06-07 00:01:08 UTC
(rev 1347)
+++ trunk/testset/maintainer-scripts/debian/postinst 2008-06-07 00:07:24 UTC
(rev 1348)
@@ -133,3 +133,6 @@
# But stopping it is fine -- we may be working around something else.
start-stop-daemon --stop --quiet --name foo --startas /usr/bin/foo
+
+# Deprecated chown use with flags.
+chown -R root.root /usr/share/doc/maintainer-scripts
Modified: trunk/testset/tags.maintainer-scripts
===================================================================
--- trunk/testset/tags.maintainer-scripts 2008-06-07 00:01:08 UTC (rev
1347)
+++ trunk/testset/tags.maintainer-scripts 2008-06-07 00:07:24 UTC (rev
1348)
@@ -37,6 +37,7 @@
W: maintainer-scripts: ancient-dpkg-multi-conrep-check preinst:10
W: maintainer-scripts: ancient-dpkg-predepends-check preinst:7
W: maintainer-scripts: config-does-not-load-confmodule
+W: maintainer-scripts: deprecated-chown-usage postinst:138 'chown -R root.root'
W: maintainer-scripts: deprecated-chown-usage postinst:33 'chown root.root'
W: maintainer-scripts: gconftool-used-in-maintainer-script postinst:68
W: maintainer-scripts: init.d-script-not-marked-as-conffile /etc/init.d/foo
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
