On Sat, 2008-11-29 at 22:47 +0000, Adam D. Barratt wrote: > On Sat, 2008-11-29 at 17:00 +0100, Frank Lichtenheld wrote: > > While I don't doubt that your patch accomplishes it goal, I wonder > > whether it would be better to fix this "correctly" now. By this > > I mean: > > > > 1) The extended description should be available in the $tag_info [...] > Descriptions are now stored along with the rest of the tag data read by > the frontend. I considered doing it directly in Tags.pm but it seemed > cleaner not to have add_tag() modify the tag data directly. The > formatting work itself is all abstracted in Read_taginfo.pm so it can be > reused elsewhere.
Ideally, the description formatting should probably be in the output modules themselves. The main reason I didn't do that is that having tried several times I was unable to call Read_taginfo::format_tag_description from Output/LetterQualifier.pm. I'm probably missing something obvious but after use()ing or require()ing Read_taginfo from the output module, attempting to call it always results in an "undefined subroutine &Read_taginfo::format_tag_description" error. Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
