Cyril Brulebois <cyril.bruleb...@kerlabs.com> writes:
> first, sorry Russ, I hope you won't find I'm trying to eat your time a
> bit more with desktop files, but that check might be quite easy to
> implement, and useful because of #439717 (cdbs not calling dh_desktop
> but for the gnome.mk class).
>
> Summary: dh_desktop is only needed so that the approriate
> update-desktop-database call is added when there are some desktop files
> embedding MimeTypes (see dh_desktop(1)).
Right.
> I know there's already a check for missing dh_desktop call (#409138),
> but it isn't triggered e.g. on the thunar source package
> (thunar-data containing the following file:
> /usr/share/thumbnailers/thunar-vfs-font-thumbnailer-1.desktop).
This particular example confuses me. I'm not sure what good a dh_desktop
call would do you here. This desktop file is installed in
/usr/share/thumbnailers rather than in /usr/share/applications; does
anything actually look at it other than thunar itself?
update-desktop-database wouldn't see it; I believe it only indexes
/usr/share/applications, /usr/local/share/applications, and
/usr/share/gdm/applications.
According to apt-file, the only packages in Debian that ship files into
/usr/share/thumbnailers are thunar and thunar-thumbnailers.
> Looking at the source, the “unless ($includes) {” in check/rules
> explains why the warning isn't shown for that particular package.
Yes, Lintian's rules checks mostly throw up their hands if there are
makefile includes. But I started looking at implementing what you state
below, and realized that Lintian wouldn't notice this anyway because the
desktop file is installed in a different path. Lintian only looks in
/usr/share/applications for desktop files (there are files all over the
file system that use the same extension and are in different directories,
but they mostly don't comply with the current standard and checking them
became far more trouble than it was worth).
This, however:
> I think it would make a bit more sense to check for the actual contents
> of the maintainers scripts for a missing update-desktop-database call
> (that is: if there are .desktop files (under /usr/share only?) which
> contain MimeTypes, and no occurrence of update-desktop-database in the
> maintainer scripts), like (I believe) it's done for update-rc.d and the
> like.
is a very good idea, and I think I'll still implement it, even if it isn't
useful for thunar. I think this is better than the existing dh_desktop
check.
--
Russ Allbery (r...@debian.org) <http://www.eyrie.org/~eagle/>
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
