The following commit has been merged in the master branch:
commit 16defe21daa2086404a8ad9ae841ca8349302aae
Author: Adam D. Barratt <[email protected]>
Date:   Fri Jan 2 19:17:22 2009 +0000

    Flag the use of "source foo" as a bashism

diff --git a/checks/scripts b/checks/scripts
index aae51e8..f04e4dd 100644
--- a/checks/scripts
+++ b/checks/scripts
@@ -615,7 +615,7 @@ while (<SCRIPTS>) {
                my @bashism_single_quote_regexs = (
                  $LEADIN . 
qr'echo\s+(?:-[^e\s]+\s+)?\'[^\']*(\\[\\abcEfnrtv0])+.*?[\']',
                        # unsafe echo with backslashes
-                 $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$)[^\s]+',
+                 $LEADIN . qr'source\s+[\"\']?(?:\.\/|\/|\$|[\w.-])[^\s]+',
                        # should be '.', not 'source'
                );
                my @bashism_string_regexs = (
diff --git a/debian/changelog b/debian/changelog
index ee585c7..56959aa 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -93,7 +93,8 @@ lintian (2.1.4) UNRELEASED; urgency=low
     + [ADB] More intelligently remove comments from shell scripts, to avoid
       removing some constructs that aren't comments, such as those in
       [ $# -gt 2 ] and "foo # bar".
-    + [ADB] Flag the source bashism when its argument is quoted.
+    + [ADB] Flag the source bashism when its argument is quoted or a bare
+      filename.
   * checks/watch-file:
     + [RA] Recognize additional SourceForge URLs and recommend the
       redirector.  Thanks, Riccardo Stagni.  (Closes: #510398)

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to