The following commit has been merged in the master branch:
commit 3113885213078638925731e694ebd1b298fb67d1
Author: Russ Allbery <[email protected]>
Date:   Sun Feb 1 11:06:24 2009 -0800

    Stop setting $/ in checks/fields
    
    * checks/fields:
      + [RA] Stop pointlessly setting $/ while parsing debian/rules and then
        restoring it to the wrong value, which broke -i when issuing some
        tags if they were the first tags issued.

diff --git a/checks/fields b/checks/fields
index 65bf9b2..f17e4c0 100644
--- a/checks/fields
+++ b/checks/fields
@@ -603,7 +603,6 @@ if ($type eq "source") {
        open (RULES, '<', "debfiles/rules")
            or fail("cannot read debfiles/rules: $!");
        my $target = "none";
-       local $/ = "\n";        # Read this linewise
        my @rules = qw(clean binary-arch build-arch);
         my $maybe_skipping;
        while (<RULES>) {
@@ -660,7 +659,6 @@ if ($type eq "source") {
                }
        }
        close RULES;
-       $/ = undef;             # Back to reading everything.
 
        tag "build-depends-indep-without-arch-indep", ""
                if (defined $info->field('build-depends-indep') && 
$arch_indep_packages == 0);
diff --git a/debian/changelog b/debian/changelog
index 5e04988..02c4672 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,7 @@
 lintian (2.2.2) UNRELEASED; urgency=low
 
+  The "this is why spooky action at a distance is bad" release.
+
   * checks/copyright-file:
     + [ADB] Treat the new copyright file format's "License-Alias: Perl" as
       indicating that the package is licensed under the same terms as Perl.
@@ -10,6 +12,10 @@ lintian (2.2.2) UNRELEASED; urgency=low
   * checks/debhelper:
     + [RA] Remove stray localization of $/, which broke -i when issuing
       tags about ${misc:Depends}.
+  * checks/fields:
+    + [RA] Stop pointlessly setting $/ while parsing debian/rules and then
+      restoring it to the wrong value, which broke -i when issuing some
+      tags if they were the first tags issued.
   * checks/scripts:
     + [RA] Add nickle as a known interpreter.  Patch from Julien Cristau.
       (Closes: #513823)

-- 
Debian package checker


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to