"Raphael Geissert" <[email protected]> writes:

> +    Lintian::Command::Simple::run('mkdir', '-p', "strings/$dir") == 0
> +     or fail("Failed to create directory 'strings/$dir'\n");

Minor thing, but I'd use File::Path::make_path here.  Although I suppose
it's a wash either way on both simplicity and speed.  I tend to have a
kneejerk dislike of running subcommands, but loading a module is probably
equally slow.

-- 
Russ Allbery ([email protected])               <http://www.eyrie.org/~eagle/>


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]

Reply via email to