-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2011-01-07 04:38, Russ Allbery wrote: > A couple of quick notes on recent commits: >
Hey, > * Lintian's coding style is all over the map and different in different > files, so there isn't much to stay consistent with, and I don't think > the exact details of the coding style matter. So take this just as a > personal preference, and feel free to ignore it. But I do personally > prefer a space between if, for, while, and similar keywords and the > parenthesis that contains the expression. > Personally I do not feel strongly either way, so I do not mind following this code style. Perhaps we could spent a bit of time defining the style we want lintian to be written in? With the work we are doing in the infra-513663, then a reasonable amount of code will be touched. > * For the Git commit messages, the best practice in the Git community is: > > Short summary of commit > > Extended description as a paragraph with multiple sentences, as long > as needed to explain the change. > > with the first line shorter than 50 characters or so and not ending in a > period, and a blank line between that line and any subsequent > description. > > This too doesn't really matter, but it will make the summary of commits > shown in, for example, git log --pretty=oneline or in the mail message > from annotated tags read more nicely. > Some of those log messages look directly awful! Sorry, my bad! ~Niels -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNKfKdAAoJEAVLu599gGRCiNIP/0d4XKsmafp4c0AtmIgCN653 cuOc3e9c+uBJrxJsN4oDTggIJQLtB0Ltqs5Ya3nqjuGOeFHe0T3foqcXc/csPXQ4 fcGjM3pQWe4BldxbYcH46XzgM7vJ8e3hnnLVVaLIQg3pBv3LkIb5LkOSnhd1FZh0 ihgjAYb+DWgEHbosL7UFih09SmH1f8dYuMU8pXYORXTdW0ZbvVmtnvcpDge6JN2p kYpt3wY3a00lduAosFCDeJsx6uXv7wpjDoIJySdL6bFMIIjew/x/qwNRRvVc65Hl vDPHNQoXjeSs5uQylW4zb1Vv9uw1SXNBQ9Y6aPXarvlUMZkcX+dwB/FtEADqlK4g FNZP8bmqY7GK4CnrAZz1GSb+joBC9wTRQrUaTfHl11RRUIYlb5gXqoA7d6gAtaBS +mzTOWgfMnhjY/jveDXfQUP+ya5fVocfdLWJ+RyYY8C8qUDGJga//lkdmnYKfxCV piOyTdSUER6DZn+UlMOtaqt/P707obWjCOLJoliUI2LqG9DzvnXyVrwJPjXmXnIU 7MLHvnb2ahO8fHDuYXe9mUkyPaJ9JVs8SrTlRohgenxU4Nf06S+vCpfHIr2KRQct OD/TUUXs7kE5nze+Y2r1YATo5Wj4HlDkcrLiNoibhMTpDZGVZLz4fRvo0J75JA4F ymTYE3QZKuoPH1CIlLtT =b/K6 -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
