-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 2011-01-20 05:52, Raphael Geissert wrote: > Niels Thykier wrote: >> - # give a chance to other jobs to finish while we >> - # process other stuff: >> - last; >> + # If that node allowed us to start on another, then we >> + # leave this loop. >> + last unless ($map->selectable()); >> } > > This change should be reverted or a second condition added; after taking a > better look at the code, you will see that below that loop there's the code > that loads the overrides file. > > With your change, if the overrides-file collection script is done, lintian > will have to wait until the next collection script is done for it to load > the overrides and start running the checks. > > I'm more inclined to just reverting it, as it only really saves one call to > 'print' but adds another call to 'selectable()'. > > Cheers,
Hey I see your point and I have reverted the commit. ~Niels -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBCAAGBQJNOqz3AAoJEAVLu599gGRCm3AP/2W0E6O+mwDVluwynfHXDnpm ei/wtV6ProyZesmb7RsKI5tdTGl6uU4PDnZF7BmCh+SFYLL9Gx1lviRDnKBKOvVl I078vDPan6o5xlDBTPhkoOG9oe8K79hh863JDHJDTUbUxlpTlbAfRg+DzFnBcOMM kJigyUi+anyxxnG9NOPEyx8U8lVOq2XlIOdCMDixPZZXl4vFIU5CBfcfsWn5Vl4L yqLbg9GazJJP/spDGGai/iY3+k3cl+5KFLyT66ZYZ3vR5HvJF2OfYk9WYrZqNxro 7iOQasyJD/MA8fYAxYed8Ok2xRRi7rSyOiXf7ENpV3+xhJKBZC9gu5k3g1jD0jIW 2plPdRWIVZ29IEvGjScm9bgH7V7xM4+NqTAYvPzxGtyLY28cBLe4w5EVzBvN7aA9 o2fykizSctgmKe1f45tbaH+mE69flA3t03b7pYpH4A6094gfoc0hR4TL2jlXMZaU NeUSl5+ZzucRMtfBJd6gEayeLfbSe9OzW+l5yDm8jfZcDhdDkfAEo1QMwo/0jDBj wEXqIssgT6V2GkBIfK71pw/YfLnHIoz5vMzmCDCd1jCpk1am5tS39R+FBUZEbvbT lltXUoP5ljisPcJwuOAvw4wRjTFNAq5mhiNBSGga/SX4piV2N6uUbIYd5C8sSO/i o4KoBy47ZevZVsa9STrQ =WMxd -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
