Hi, On Tue, Jul 27, 2010 at 12:42:08AM +0100, Iain Lane wrote:
tags 588873 + patch thanksHiya, On Sun, Jul 25, 2010 at 06:29:06PM -0700, Russ Allbery wrote:Iain Lane <[email protected]> writes:I'd dlike to propose a new check which is analogous to patch-system-but-direct-changes-in-diff but for 3.0 (quilt).[...]What do you think? If the consensus is that this is a good idea then I'll have a go at implementing.Most of my packages intentionally have only that patch. Maybe only trigger it if debian/source/patch-header doesn't exist and mention that if this is intentional, creating that file allows adding a custom header to the generated patch explaining why this is done? That could avoid the numerous false positives of patch-system-but-direct-changes-in-diff and make it less wild-guessy. Otherwise, seems like a good idea to me.Thanks. This was easier than I thought it would be to cook up: attached. My first Lintian patch; please review for code style.It might be worth checking for single-debian-patch and no patch-header too, but that would be something else.
Ping — any chance of a review/merge? Iain
signature.asc
Description: Digital signature
