On 2013-02-22 04:54, Vasudev Kamath wrote: > On Thu, Feb 21, 2013 at 11:31 PM, Niels Thykier <[email protected]> wrote: >> >> Thanks for the patches, these have been merged[1]. >> >> When reviewing your patch today, I realised that it was possible to >> simplify the "inner if" by using an additional argument to $info->field. >> I have attached a small patch showing the changes I did for comparison. > > Ah yes I didn't think of using DEFAULT feature of $info->field.
It is fairly very new [July 2012] and (sadly) a very underused feature :) > I noted that I missed to fix a test case for files-adobe-font, I guess > since I didn't run entire test case (ran only fields) I didn't catch > it. > > Thanks > Exactly, it would have required "onlyrun=files" (or a full run). Though, a full run can easily take over 30 minutes - I have tried to improve it, but it is still pretty bad. #699083 has some of the most recent numbers. ~Niels -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
