The following commit has been merged in the master branch:
commit e323d72c2e48e402f7b39da733db6ec1adb67cd7
Author: Niels Thykier <[email protected]>
Date: Sat Mar 30 13:27:43 2013 +0100
t: Enable perl critic test by default (with reduced policy)
Instead of having a strict policy we never enforce, have a small
policy we currently follow and can enforce.
Signed-off-by: Niels Thykier <[email protected]>
diff --git a/.perlcriticrc b/.perlcriticrc
index 1eefd77..a7b91ad 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -1,3 +1,4 @@
+# -*- conf -*-
# FIXME: the list of checks should probably be moved to
# t/scripts/critic.pl. Line continuations are not supported here
@@ -7,7 +8,7 @@ severity = 1
# Work based on a whitelist
only = 1
# Our whitelist (ignores severity):
-include = MixedBooleanOperators ExplicitReturnUndef InteractiveTest
GlobFunction UpperCaseHeredoc NegativeIndices PrivateVars UselessInitialization
UnusedVariables ReusedNames PackageVars MatchVars ConditionalDeclarations
NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings
SingleCharAlternation UnusedCapture FixedStringMatches EndWithOne
ConditionalUseStatements TwoArgOpen PackageMatchesPodName JoinedReadline
UnreachableCode QuotedWordLists TrailingWhitespace InterpolationOfLiterals
ImplicitNewlines CommaSeparatedStatements
+#include = MixedBooleanOperators ExplicitReturnUndef InteractiveTest
GlobFunction UpperCaseHeredoc NegativeIndices PrivateVars UselessInitialization
UnusedVariables ReusedNames PackageVars MatchVars ConditionalDeclarations
NumberSeparators NullStatements LongChainsOfMethodCalls UseStrict UseWarnings
SingleCharAlternation UnusedCapture FixedStringMatches EndWithOne
ConditionalUseStatements TwoArgOpen PackageMatchesPodName JoinedReadline
UnreachableCode QuotedWordLists TrailingWhitespace InterpolationOfLiterals
ImplicitNewlines CommaSeparatedStatements
# If you want to try some other stuff, uncomment the following
# (exclude is an incomplete list of things we probably won't change)
diff --git a/debian/control b/debian/control
index 353c40e..4bfffaf 100644
--- a/debian/control
+++ b/debian/control
@@ -35,6 +35,7 @@ Build-Depends: binutils,
libipc-run-perl,
libparse-debianchangelog-perl,
libtest-minimumversion-perl,
+ libtest-perl-critic,
libtest-pod-coverage-perl,
libtest-pod-perl,
libtest-strict-perl,
diff --git a/t/scripts/critic.t b/t/scripts/critic.t
index 1bb32c1..b4e1930 100755
--- a/t/scripts/critic.t
+++ b/t/scripts/critic.t
@@ -38,8 +38,6 @@ sub should_skip() {
my $skip = 1;
my $pid;
- return $skip unless (defined ($ENV{'CRITICISE'}));
-
$pid = open (DPKG, '-|', 'dpkg-parsechangelog', '-c0');
die("failed to execute dpkg-parsechangelog: $!")
--
Debian package checker
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]
