The following commit has been merged in the master branch:
commit e50f171bf3d3e94ecd29c8002dfa003ed377e5ea
Author: Niels Thykier <[email protected]>
Date: Tue Apr 2 18:13:11 2013 +0200
Enable more perlcritic policies
Have perlcritic check for "hard tabs", "mixed operators" and indirect
"object" syntax (e.g. new Package::Name).
Signed-off-by: Niels Thykier <[email protected]>
diff --git a/.perlcriticrc b/.perlcriticrc
index 649d14b..deeb2e6 100644
--- a/.perlcriticrc
+++ b/.perlcriticrc
@@ -8,8 +8,8 @@ severity = 1
# Work based on a whitelist
only = 1
# Our whitelist (ignores severity):
-include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars
UselessInitialization MatchVars NumberSeparators NullStatements
LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne
ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode
TrailingWhitespace InterpolationOfLiterals ImplicitNewlines
CommaSeparatedStatements UseStrict UseWarnings UnusedVariables UnusedCapture
TwoArgOpen
-#include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc ReusedNames
PackageVars ConditionalDeclarations SingleCharAlternation FixedStringMatches
EndWithOne ConditionalUseStatements QuotedWordLists
+include = ExplicitReturnUndef GlobFunction NegativeIndices PrivateVars
UselessInitialization MatchVars NumberSeparators NullStatements
LongChainsOfMethodCalls UseStrict UseWarnings EndWithOne
ConditionalUseStatements PackageMatchesPodName JoinedReadline UnreachableCode
TrailingWhitespace InterpolationOfLiterals ImplicitNewlines
CommaSeparatedStatements UseStrict UseWarnings UnusedVariables UnusedCapture
TwoArgOpen ProhibitHardTabs MismatchedOperators IndirectSyntax
+#include = MixedBooleanOperators InteractiveTest UpperCaseHeredoc ReusedNames
PackageVars ConditionalDeclarations SingleCharAlternation FixedStringMatches
ConditionalUseStatements QuotedWordLists
# If you want to try some other stuff, uncomment the following
# (exclude is an incomplete list of things we probably won't change)
@@ -31,3 +31,4 @@ allow_if_string_contains_single_quote = 1
[ValuesAndExpressions::ProhibitCommaSeparatedStatements]
allow_last_statement_to_be_comma_separated_in_map_and_grep = 1
+
diff --git a/checks/fields b/checks/fields
index 5f74a6f..ef1ac32 100644
--- a/checks/fields
+++ b/checks/fields
@@ -275,7 +275,7 @@ if (not defined $info->field('version')) {
$expected =~ s/[\.\+\-\:]?\Q$rc\E.*//;
$suggestion = "$expected~$rc$rest";
tag 'rc-version-greater-than-expected-version', $upstream, '>',
$expected, "(consider using $suggestion)",
- if $info->native or ($debian eq 1 or $debian =~
m,^0(?:\.1|ubuntu1)?$,);
+ if $info->native or ($debian eq q{1} or $debian =~
m,^0(?:\.1|ubuntu1)?$,);
}
# Checks for the dfsg convention for repackaged upstream
--
Debian package checker
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]