Package: lintian Version: 2.5.15 Severity: normal Tags: patch X-Debbugs-CC: [email protected]
Dear maintainers, I provide a patch to fix this tags. Tag: pecl-package-requires-build-dependency Info: The package is a PECL package but its control file doesn't have php5-dev or dh-php5 as a build dependency. Regards, Prach
>From 1aeeb4cb213616776fd163dac4be3a8fe6bcabca Mon Sep 17 00:00:00 2001 From: Prach Pongpanich <[email protected]> Date: Tue, 27 Aug 2013 01:04:03 +0700 Subject: [PATCH] Correct condition for pecl-package-requires-build-dependency --- checks/phppear.pm | 7 ++----- t/tests/phppear-pear/tags | 3 +-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/checks/phppear.pm b/checks/phppear.pm index 2447992..3013646 100644 --- a/checks/phppear.pm +++ b/checks/phppear.pm @@ -99,12 +99,9 @@ sub run { } close($package_xml_fd); if ($package_type eq 'extsrc') { # PECL package - if (!$bdepends->implies('php5-dev')) { + if (!$bdepends->implies('php5-dev') && !$bdepends->implies('dh-php5')) { tag 'pecl-package-requires-build-dependency', - 'php5-dev'; - } - if (!$bdepends->implies('dh-php5')) { - tag 'pecl-package-requires-build-dependency','dh-php5'; + 'php5-dev or dh-php5'; } if (!$bdepends->implies('pkg-php-tools (>= 1.5~)')) { tag diff --git a/t/tests/phppear-pear/tags b/t/tests/phppear-pear/tags index e01731b..fd8c7e6 100644 --- a/t/tests/phppear-pear/tags +++ b/t/tests/phppear-pear/tags @@ -9,5 +9,4 @@ W: phppear-pear source: pear-package-but-missing-dependency Recommends W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.4~) for package2.xml W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1.5~) for PECL support W: phppear-pear source: pear-package-feature-requires-newer-pkg-php-tools (>= 1~) for package name overrides -W: phppear-pear source: pecl-package-requires-build-dependency dh-php5 -W: phppear-pear source: pecl-package-requires-build-dependency php5-dev +W: phppear-pear source: pecl-package-requires-build-dependency php5-dev or dh-php5 -- 1.8.4.rc3
