Simon McVittie:
> After getting this wrong in Flatpak, I have attached a proposed patch
> for a new "gir" family of checks.
> [...]
>     S

Thanks for creating a patch for this. :)

At first glance, I only have a few minor tweaks/recommendations. :)

In checks/gir.desc:
+Reference: file:///usr/share/doc/gobject-introspection/policy.txt

The field is "Ref" (consistent error)

+    if (my $xmldir = $info->index_resolved_path('usr/share/gir-1.0')) {
+        push @girs, $xmldir->children;
+    }
+    if (my $dir = $info->index_resolved_path('usr/lib/girepository-1.0')) {
+        push @typelibs, $dir->children;

Can give undef warnings if someone was "evil" enough to make the paths a
file or a symlink.  Trivial work-around is to change the path end with a
slash (e.g. 'usr/share/gir-1.0/'). This makes index_resolved_path return
undef if the path is not a directory.


Reply via email to