This is an automated email from the git hooks/post-receive script. lamby pushed a commit to branch master in repository lintian.
commit d1fd39eb2493ac8ec3752c800871b33b7fe54a38 Author: Chris Lamb <[email protected]> Date: Mon Jul 17 22:54:51 2017 +0100 Check for useless build-dependencies on dh-autoreconf or autotools-dev under compat levels 10 or higher. (Closes: #844191) --- checks/debhelper.desc | 9 +++++++++ checks/debhelper.pm | 7 +++++++ debian/changelog | 3 +++ .../debian/debian/compat | 1 + .../debian/debian/control.in | 15 +++++++++++++++ t/tests/debhelper-autoreconf-build-depends/desc | 6 ++++++ t/tests/debhelper-autoreconf-build-depends/tags | 2 ++ 7 files changed, 43 insertions(+) diff --git a/checks/debhelper.desc b/checks/debhelper.desc index 9377b90..fc5532a 100644 --- a/checks/debhelper.desc +++ b/checks/debhelper.desc @@ -369,3 +369,12 @@ Info: Lines in a <tt>debian/*.maintscript</tt> correspond to <tt>dpkg-maintscript-helper(1)</tt> commands and parameters. However, the "maint-script-parameters" should not be included as debhelper will add those automatically. See <tt>dh_installdeb(1)</tt> for more information. + +Tag: useless-autoreconf-build-depends +Severity: normal +Certainty: possible +Info: Since compatibility level 10, debhelper enables the <tt>autoreconf</tt> + sequence by default. + . + It is therefore not necessary to specify build-dependencies on + <tt>dh-autoreconf</tt> or <tt>autotools-dev</tt> and they can be removed. diff --git a/checks/debhelper.pm b/checks/debhelper.pm index 1dd99d5..a0aa3d0 100644 --- a/checks/debhelper.pm +++ b/checks/debhelper.pm @@ -453,6 +453,13 @@ sub run { tag $tagname, @extra; } + if ($level >= 10) { + for my $pkg (qw(dh-autoreconf autotools-dev)) { + tag 'useless-autoreconf-build-depends', $pkg + if $bdepends->implies($pkg); + } + } + if ($seen_dh and not $seen_python_helper) { my %python_depends; for my $binpkg (@pkgs) { diff --git a/debian/changelog b/debian/changelog index 0f1d4a5..7afea54 100644 --- a/debian/changelog +++ b/debian/changelog @@ -34,6 +34,9 @@ lintian (2.5.52) UNRELEASED; urgency=medium (Closes: #868178) + [CL] Check for "FIXME" and similar placeholders in various files under debian/. (Closes: #846009) + * checks/debhelper.{desc,pm}: + + [CL] Check for useless build-dependencies on dh-autoreconf or + autotools-dev under compat levels 10 or higher. (Closes: #844191) * checks/elpa.{desc,pm}: + [NT] Apply patch from Sean Whitton to add elpa related checks. (Closes: #867042) diff --git a/t/tests/debhelper-autoreconf-build-depends/debian/debian/compat b/t/tests/debhelper-autoreconf-build-depends/debian/debian/compat new file mode 100644 index 0000000..f599e28 --- /dev/null +++ b/t/tests/debhelper-autoreconf-build-depends/debian/debian/compat @@ -0,0 +1 @@ +10 diff --git a/t/tests/debhelper-autoreconf-build-depends/debian/debian/control.in b/t/tests/debhelper-autoreconf-build-depends/debian/debian/control.in new file mode 100644 index 0000000..8984bdc --- /dev/null +++ b/t/tests/debhelper-autoreconf-build-depends/debian/debian/control.in @@ -0,0 +1,15 @@ +Source: {$source} +Priority: extra +Section: {$section} +Maintainer: {$author} +Standards-Version: {$standards_version} +Build-Depends: {$build_depends}, debhelper (>= 10), dh-autoreconf, autotools-dev + +Package: {$source} +Architecture: {$architecture} +Depends: $\{shlibs:Depends\}, $\{misc:Depends\} +Description: {$description} + This is a test package designed to exercise some feature or tag of + Lintian. It is part of the Lintian test suite and may do very odd + things. It should not be installed like a regular package. It may + be an empty package. diff --git a/t/tests/debhelper-autoreconf-build-depends/desc b/t/tests/debhelper-autoreconf-build-depends/desc new file mode 100644 index 0000000..78f7f1c --- /dev/null +++ b/t/tests/debhelper-autoreconf-build-depends/desc @@ -0,0 +1,6 @@ +Testname: debhelper-autoreconf-build-depends +Version: 1.0 +Description: Test for useless autoreconf-related build dependencies +Test-Depends: debhelper (>= 10) +Test-For: + useless-autoreconf-build-depends diff --git a/t/tests/debhelper-autoreconf-build-depends/tags b/t/tests/debhelper-autoreconf-build-depends/tags new file mode 100644 index 0000000..ba84b51 --- /dev/null +++ b/t/tests/debhelper-autoreconf-build-depends/tags @@ -0,0 +1,2 @@ +W: debhelper-autoreconf-build-depends source: useless-autoreconf-build-depends autotools-dev +W: debhelper-autoreconf-build-depends source: useless-autoreconf-build-depends dh-autoreconf -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
