This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch master
in repository lintian.

commit 213f0301aeee5e4d71d258156f15a176c5c0ea51
Author: Bastien ROUCARIÈS <roucaries.bastien+deb...@gmail.com>
Date:   Fri Aug 11 22:02:48 2017 +0200

    Avoid false positive for link to license
    
    It is not a privacy breach. Future lintian could suggest to replace with 
local link nevertheless
---
 checks/files.pm                                                | 10 ++++++++++
 debian/changelog                                               |  2 ++
 .../src/old-false-positive/privacy-breach-generic/legal.xml    |  5 +++++
 3 files changed, 17 insertions(+)

diff --git a/checks/files.pm b/checks/files.pm
index 6e5f85e..af91648 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -2027,6 +2027,15 @@ sub _check_tag_url_privacy_breach {
         }
     }
 
+    # False positive
+    # legal.xml file of gnome
+    # could be replaced by a link to local file but not really a privacy breach
+    if(    $file->basename eq 'legal.xml'
+        && $tagattr eq 'link'
+        &&  $website =~ m{^creativecommons.org/licenses/}) {
+        return;
+    }
+
     # track well known site
     foreach my $breaker ($PRIVACY_BREAKER_WEBSITES->all) {
         my $value = $PRIVACY_BREAKER_WEBSITES->value($breaker);
@@ -2042,6 +2051,7 @@ sub _check_tag_url_privacy_breach {
             return;
         }
     }
+
     # generic case
     unless (exists $privacybreachhash->{'tag-generic-'.$website}){
         tag 'privacy-breach-generic', $file, "($url)";
diff --git a/debian/changelog b/debian/changelog
index df8c2f5..69381fd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -36,6 +36,8 @@ lintian (2.5.53) UNRELEASED; urgency=medium
     + [CL] Ensure that python3-foo packages have "Section: python", not
       just python2-foo.  (Closes: #870272)
     + [RG] Do no longer require debug packages to be priority extra.
+  * checks/files.pm:
+    + [BR] Avoid false positive privacy-breach-generic for legal.xml.
   * checks/init.d.desc:
     + [RG] Do not recommend a versioned dependency on lsb-base in
       init.d-script-needs-depends-on-lsb-base.  (Closes: #847144)
diff --git 
a/t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml
 
b/t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml
new file mode 100644
index 0000000..cb5d83f
--- /dev/null
+++ 
b/t/tests/files-privacybreach/debian/src/old-false-positive/privacy-breach-generic/legal.xml
@@ -0,0 +1,5 @@
+<license xmlns="http://projectmallard.org/1.0/";
+         href="http://creativecommons.org/licenses/by-sa/3.0/";>
+  <p>This work is licensed under a <link 
href="http://creativecommons.org/licenses/by-sa/3.0/";>Creative
+  Commons Attribution-ShareAlike 3.0 Unported License</link>.</p>
+</license>

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Reply via email to