This is an automated email from the git hooks/post-receive script. lamby pushed a commit to branch master in repository lintian.
commit b2c73b56774505439b774e256616212102a0f804 Author: Chris Lamb <[email protected]> Date: Mon Nov 20 08:55:49 2017 +0900 Only warn about well-known insecure URIs in homepage-field-uses-insecure-uri. --- checks/fields.pm | 5 ++++- debian/changelog | 4 ++-- .../fields-homepage-field-uses-insecure-uri/debian/debian/control.in | 2 +- t/tests/fields-homepage-field-uses-insecure-uri/tags | 4 ++-- 4 files changed, 9 insertions(+), 6 deletions(-) diff --git a/checks/fields.pm b/checks/fields.pm index 6ff4dc4..c0b9e96 100644 --- a/checks/fields.pm +++ b/checks/fields.pm @@ -629,7 +629,10 @@ sub run { if ($homepage=~ m,bioconductor\.org/packages/.*/bioc/html/.*\.html*$,){ tag 'homepage-for-bioconductor-package-not-canonical', $orig; } - if ($homepage=~ m,^http:,){ + if ( $homepage =~ m,^ftp//, + or $homepage =~ + =~ m,^http://(?:[^\.]+\.)?(?:github\.com|metacpan\.org|debian\.org)/, + ){ tag 'homepage-field-uses-insecure-uri', $orig; } } elsif (not $info->native) { diff --git a/debian/changelog b/debian/changelog index a4d1e3f..889dac7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -11,8 +11,8 @@ lintian (2.5.60) UNRELEASED; urgency=medium + [AB] Also mention Emacs' "M-x wh-cl" (whitespace-cleanup) for file-contains-trailing-whitespace. * checks/fields.desc: - + [CL] Warn for Homepage files using insecure URIs such as HTTP or - FTP, similar to vcs-field-uses-insecure-uri. (Closes: #849514) + + [CL] Warn for Homepage files using well-known insecure URIs. + (Closes: #849514) * checks/version-substvars.desc: + [CL] Don't recommend "Source-Version" in tag descriptions. diff --git a/t/tests/fields-homepage-field-uses-insecure-uri/debian/debian/control.in b/t/tests/fields-homepage-field-uses-insecure-uri/debian/debian/control.in index 769dc3b..f78b977 100644 --- a/t/tests/fields-homepage-field-uses-insecure-uri/debian/debian/control.in +++ b/t/tests/fields-homepage-field-uses-insecure-uri/debian/debian/control.in @@ -5,7 +5,7 @@ Maintainer: {$author} Standards-Version: {$standards_version} Build-Depends: {$build_depends} Rules-Requires-Root: no -Homepage: http://insecure.example.com/ +Homepage: http://github.com/insecure/uri Package: {$source} Architecture: {$architecture} diff --git a/t/tests/fields-homepage-field-uses-insecure-uri/tags b/t/tests/fields-homepage-field-uses-insecure-uri/tags index 7425c77..d56de80 100644 --- a/t/tests/fields-homepage-field-uses-insecure-uri/tags +++ b/t/tests/fields-homepage-field-uses-insecure-uri/tags @@ -1,2 +1,2 @@ -P: fields-homepage-field-uses-insecure-uri source: homepage-field-uses-insecure-uri http://insecure.example.com/ -P: fields-homepage-field-uses-insecure-uri: homepage-field-uses-insecure-uri http://insecure.example.com/ +P: fields-homepage-field-uses-insecure-uri source: homepage-field-uses-insecure-uri http://github.com/insecure/uri +P: fields-homepage-field-uses-insecure-uri: homepage-field-uses-insecure-uri http://github.com/insecure/uri -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
